linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <bbrezillon@kernel.org>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Stefan Roese <sr@denx.de>
Cc: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	Vignesh R <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@microchip.com>,
	linux-spi@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
	Frieder Schrempf <frieder.schrempf@exceet.de>,
	Mark Brown <broonie@kernel.org>,
	linux-mtd@lists.infradead.org,
	Piotr Bugalski <bugalski.piotr@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 6/7] mtd: spinand: Use the spi-mem dirmap API
Date: Thu, 24 Jan 2019 09:49:44 +0100	[thread overview]
Message-ID: <20190124094944.726dd4e0@bbrezillon> (raw)
In-Reply-To: <20181106160536.13415-7-boris.brezillon@bootlin.com>

Hi Miquel,

On Tue,  6 Nov 2018 17:05:35 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> Make use of the spi-mem direct mapping API to let advanced controllers
> optimize read/write operations when they support direct mapping.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Can we drop/revert this patch until we find out what's going on with
Stefan's setup. 

> +const struct spi_mem_op *
> +spinand_find_supported_op(struct spinand_device *spinand,
> +			  const struct spi_mem_op *ops,
> +			  unsigned int nops)
> +{
> +	unsigned int i;
> +
> +	for (i = 0; i < nops; i++) {
> +		if (spi_mem_supports_op(spinand->spimem, &ops[i]))
> +			return &ops[i];
> +	}
> +
> +	return NULL;
> +}
> +

Looks like this function is never used. Probably a leftover from
early versions of this patch :-/.

Regards,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2019-01-24  8:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 16:05 [PATCH v3 0/7] spi: spi-mem: Add a direct mapping API Boris Brezillon
2018-11-06 16:05 ` [PATCH v3 1/7] spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description Boris Brezillon
2018-11-06 16:05 ` [PATCH v3 2/7] spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum Boris Brezillon
2018-11-06 16:05 ` [PATCH v3 3/7] spi: spi-mem: Split spi_mem_exec_op() code Boris Brezillon
2018-11-06 16:05 ` [PATCH v3 4/7] spi: spi-mem: Add a new API to support direct mapping Boris Brezillon
2018-11-06 16:05 ` [PATCH v3 5/7] mtd: devices: m25p80: Use the spi-mem dirmap API Boris Brezillon
2019-01-14  8:49   ` Yogesh Narayan Gaur
2019-01-14  8:59     ` Boris Brezillon
2019-01-14  9:05   ` Yogesh Narayan Gaur
2018-11-06 16:05 ` [PATCH v3 6/7] mtd: spinand: " Boris Brezillon
2019-01-15 16:45   ` Miquel Raynal
2019-01-24  8:49   ` Boris Brezillon [this message]
2018-11-06 16:05 ` [PATCH v3 7/7] spi: mxic: Add support for direct mapping Boris Brezillon
2018-11-15 19:56 ` [PATCH v3 0/7] spi: spi-mem: Add a direct mapping API Mark Brown
2018-11-19 21:13   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190124094944.726dd4e0@bbrezillon \
    --to=bbrezillon@kernel.org \
    --cc=boris.brezillon@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=bugalski.piotr@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@microchip.com \
    --cc=dwmw2@infradead.org \
    --cc=frieder.schrempf@exceet.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sr@denx.de \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).