linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jonas Bonn <jonas@norrbonn.se>,
	Baolin Wang <baolin.wang@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Lanqing Liu <lanqing.liu@spreadtrum.com>
Subject: Re: [PATCH v3 1/2] spi: support inter-word delay requirement for devices
Date: Tue, 29 Jan 2019 16:41:43 +0000	[thread overview]
Message-ID: <20190129164143.GF10524@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdXyuWMPUdipwW0oQUdPLDyZhssZ1NHQfMF9hWTtMkTZ1A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On Tue, Jan 29, 2019 at 11:07:50AM +0100, Geert Uytterhoeven wrote:
> On Tue, Jan 29, 2019 at 10:50 AM Jonas Bonn <jonas@norrbonn.se> wrote:

> > OK.  So the user (perhaps in userspace using spidev) has to know the
> > rate of the IO clock that the SPI controller sits behind and then has to
> > match this to the required delay of the slave device...  Doesn't sound
> > very portable.

I think if we're doing translation we should just do it in the core and
either say that clients should only set one or the other or pick what
looks like the higher value.

> I can see the value of having both:
> On some slaves, the delay may depend on a fixed internal or
> external clock[1] on the SPI slave, so it should be specified in time units.
> Some slaves may be clocked by the SPI clock[2], so the delay should be
> specified in SPI clock cycles.

Yes, they're definitely both useful.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-01-29 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26 16:32 [PATCH v3 0/2] spi: support inter-word delays Jonas Bonn
2019-01-26 16:32 ` [PATCH v3 1/2] spi: support inter-word delay requirement for devices Jonas Bonn
2019-01-28 18:10   ` Mark Brown
2019-01-28 21:28     ` Jonas Bonn
2019-01-29  9:04       ` Baolin Wang
2019-01-29  9:14         ` Jonas Bonn
2019-01-29  9:35           ` Baolin Wang
2019-01-29  9:49             ` Jonas Bonn
2019-01-29 10:07               ` Geert Uytterhoeven
2019-01-29 16:41                 ` Mark Brown [this message]
2019-01-26 16:32 ` [PATCH v3 2/2] spi-atmel: support inter-word delay Jonas Bonn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129164143.GF10524@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=baolin.wang@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=jonas@norrbonn.se \
    --cc=lanqing.liu@spreadtrum.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).