From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Roese <sr@denx.de>
Cc: devel@driverdev.osuosl.org,
Sankalp Negi <sankalpnegi2310@gmail.com>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
John Crispin <john@phrozen.org>, NeilBrown <neil@brown.name>
Subject: Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup
Date: Fri, 1 Feb 2019 11:04:19 +0100 [thread overview]
Message-ID: <20190201100419.GA17779@kroah.com> (raw)
In-Reply-To: <61b2570c-84c6-ccc3-2535-4197030f2cd6@denx.de>
On Fri, Feb 01, 2019 at 10:16:23AM +0100, Stefan Roese wrote:
> On 01.02.19 10:03, Greg Kroah-Hartman wrote:
> > On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote:
> > > This patch cleans up some minor issues with this driver:
> > > - Remove unnecessary header includes
> > > - Sort header alphabetically
> > > - Use correct comment style
> > > - Add return code check on device_reset()
> > > - Remove SPI_BPW_MASK definition (already available in
> > > include/linux/spi/spi.h)
> > > - Use macros instead of hardcoded values for SPI_MASTER register access
> > > as suggested by Neil Brown (in mt7621_spi_reset and mt7621_spi_prepare)
> >
> > When you have to start listing the different things you do in a patch,
> > that's a huge sign you need to break this up into different patches :)
>
> I personally find this over complex for these type of changes, that's
> why I prefer to send such "minor" changes in a single patch. But I
> can definitely split this up into multiple patches, if this is what's
> preferred by you (and others).
When you review as many patches as we do, it's _MUCH_ easier to review a
patch that only does one thing, to verify it really does that one thing
properly. If you mix it all up, it takes a lot more effort to try to
review it all correctly.
Remember, you need to make it as easy as possible to understand the
change to make me seem horrible to reject your patch :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-01 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 8:57 [PATCH 1/2 v2] staging: spi: mt7621: Switch to SPDX identifier Stefan Roese
2019-02-01 8:57 ` [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup Stefan Roese
2019-02-01 9:03 ` Greg Kroah-Hartman
2019-02-01 9:16 ` Stefan Roese
2019-02-01 10:04 ` Greg Kroah-Hartman [this message]
2019-02-01 10:07 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201100419.GA17779@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=john@phrozen.org \
--cc=linux-spi@vger.kernel.org \
--cc=neil@brown.name \
--cc=sankalpnegi2310@gmail.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).