From: Stefan Roese <sr@denx.de>
To: linux-spi@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sankalp Negi <sankalpnegi2310@gmail.com>,
Mark Brown <broonie@kernel.org>, John Crispin <john@phrozen.org>,
NeilBrown <neil@brown.name>
Subject: [PATCH 3/9 v3] staging: spi: mt7621: Add return code check on device_reset()
Date: Fri, 1 Feb 2019 11:17:09 +0100 [thread overview]
Message-ID: <20190201101715.3760-3-sr@denx.de> (raw)
In-Reply-To: <20190201101715.3760-1-sr@denx.de>
This patch adds a return code check on device_reset() and removes the
compile warning.
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: NeilBrown <neil@brown.name>
Cc: Sankalp Negi <sankalpnegi2310@gmail.com>
Cc: Chuanhong Guo <gch981213@gmail.com>
Cc: John Crispin <john@phrozen.org>
---
v3:
- New patch, changes spilt into separate patches
drivers/staging/mt7621-spi/spi-mt7621.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c
index 440c3f77fde8..ca4632740827 100644
--- a/drivers/staging/mt7621-spi/spi-mt7621.c
+++ b/drivers/staging/mt7621-spi/spi-mt7621.c
@@ -321,6 +321,7 @@ static int mt7621_spi_probe(struct platform_device *pdev)
int status = 0;
struct clk *clk;
struct mt7621_spi_ops *ops;
+ int ret;
match = of_match_device(mt7621_spi_match, &pdev->dev);
if (!match)
@@ -368,7 +369,11 @@ static int mt7621_spi_probe(struct platform_device *pdev)
rs->pending_write = 0;
dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq);
- device_reset(&pdev->dev);
+ ret = device_reset(&pdev->dev);
+ if (ret) {
+ dev_err(&pdev->dev, "SPI reset failed!\n");
+ return ret;
+ }
mt7621_spi_reset(rs);
--
2.20.1
next prev parent reply other threads:[~2019-02-01 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 10:17 [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Stefan Roese
2019-02-01 10:17 ` [PATCH 2/9 v3] staging: spi: mt7621: Clean up excessive header usage Stefan Roese
2019-02-01 10:17 ` Stefan Roese [this message]
2019-02-01 10:17 ` [PATCH 4/9 v3] staging: spi: mt7621: Remove superfluous SPI_BPW_MASK definition Stefan Roese
2019-02-01 10:17 ` [PATCH 5/9 v3] staging: spi: mt7621: Minor cosmetic changes Stefan Roese
2019-02-01 10:17 ` [PATCH 6/9 v3] staging: spi: mt7621: Use recommended comment style Stefan Roese
2019-02-01 10:17 ` [PATCH 7/9 v3] staging: spi: mt7621: Sort register definitions Stefan Roese
2019-02-01 10:17 ` [PATCH 8/9 v3] staging: spi: mt7621: Use macros instead of hardcoded values Stefan Roese
2019-02-01 10:17 ` [PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi Stefan Roese
2019-02-03 22:42 ` NeilBrown
2019-02-01 13:03 ` [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Mark Brown
2019-02-03 22:34 ` NeilBrown
2019-02-04 8:53 ` Mark Brown
2019-02-04 23:09 ` NeilBrown
2019-02-05 6:29 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201101715.3760-3-sr@denx.de \
--to=sr@denx.de \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-spi@vger.kernel.org \
--cc=neil@brown.name \
--cc=sankalpnegi2310@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).