From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-spi@vger.kernel.org,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Mark Brown" <broonie@kernel.org>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] spi: spi-gpio: fix SPI_CS_HIGH capability
Date: Thu, 21 Feb 2019 20:21:29 +0100 [thread overview]
Message-ID: <20190221192129.GJ2061@latitude> (raw)
In-Reply-To: <CAOMZO5B_ELinMtAipaM9GP3Frj1YxRA5DmL-RJYnSE5i_W04uw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 789 bytes --]
On Thu, Feb 21, 2019 at 01:14:04PM -0300, Fabio Estevam wrote:
> On Thu, Feb 21, 2019 at 1:00 PM Russell King <rmk+kernel@armlinux.org.uk> wrote:
> >
> > spi-gpio is capable of dealing with active-high chip-selects.
> > Unfortunately, commit 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE
> > support") broke this by setting master->mode_bits, which overrides
> > the setting in the spi-bitbang code. Fix this.
> >
> > Fixes: 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support")
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> > Patch against 4.20
>
> Adding Jonathan who sent a similar fix recently:
> https://patchwork.kernel.org/patch/10804855/
Hello Russel,
your patch looks better, and I think Mark Brown has already applied it.
Thanks.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-21 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:24 [BUG] vf610-zii-dev-rev-b SPI fails at boot Russell King - ARM Linux admin
2019-02-21 15:59 ` [PATCH] spi: spi-gpio: fix SPI_CS_HIGH capability Russell King
2019-02-21 16:14 ` Fabio Estevam
2019-02-21 19:21 ` Jonathan Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221192129.GJ2061@latitude \
--to=j.neuschaefer@gmx.net \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).