From: Mark Brown <broonie@kernel.org>
To: Volker Haspel <volker.haspel@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Han Xu <han.xu@nxp.com>,
john.ogness@linutronix.de
Subject: Re: [PATCH] spi: spi-fsl-qspi: call spi_unregister_controller
Date: Mon, 11 Mar 2019 17:03:34 +0000 [thread overview]
Message-ID: <20190311170334.GA14368@sirena.org.uk> (raw)
In-Reply-To: <20190307103008.19841-1-volker.haspel@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
On Thu, Mar 07, 2019 at 11:30:08AM +0100, Volker Haspel wrote:
> The driver does not clearly unregister the spi controller.
> Therefore calling an unbind and bind again will end up in a
> Kernel crash.
> Each driver who calls spi_register_controller() in the probe function
> has to call spi_unregister_controller() too.
Why not change it to use devm?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-11 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 10:30 [PATCH] spi: spi-fsl-qspi: call spi_unregister_controller Volker Haspel
2019-03-11 17:03 ` Mark Brown [this message]
2019-03-12 8:43 ` Volker Haspel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311170334.GA14368@sirena.org.uk \
--to=broonie@kernel.org \
--cc=han.xu@nxp.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=volker.haspel@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).