* Re: [PATCH] spi: pxa2xx: Add support for Intel Comet Lake
2019-04-16 3:27 [PATCH] spi: pxa2xx: Add support for Intel Comet Lake Evan Green
@ 2019-04-16 8:00 ` Andy Shevchenko
2019-04-16 12:26 ` Jarkko Nikula
2019-04-16 16:32 ` Applied "spi: pxa2xx: Add support for Intel Comet Lake" to the spi tree Mark Brown
2019-05-02 2:19 ` Mark Brown
2 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-04-16 8:00 UTC (permalink / raw)
To: Evan Green
Cc: Mark Brown, Andy Shevchenko, Rajat Jain, Robert Jarzmik,
Haojian Zhuang, Linux Kernel Mailing List, linux-spi, Daniel Mack,
linux-arm Mailing List
On Tue, Apr 16, 2019 at 6:28 AM Evan Green <evgreen@chromium.org> wrote:
>
> Add PCI IDs for SPI on Comet Lake.
>
I didn't check IDs, perhaps Jarkko can do it.
>From other prospectives looks good.
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Evan Green <evgreen@chromium.org>
>
> ---
>
> drivers/spi/spi-pxa2xx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> index b6ddba833d021..493223e1d032d 100644
> --- a/drivers/spi/spi-pxa2xx.c
> +++ b/drivers/spi/spi-pxa2xx.c
> @@ -1451,6 +1451,10 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
> { PCI_VDEVICE(INTEL, 0xa32a), LPSS_CNL_SSP },
> { PCI_VDEVICE(INTEL, 0xa32b), LPSS_CNL_SSP },
> { PCI_VDEVICE(INTEL, 0xa37b), LPSS_CNL_SSP },
> + /* CML-LP */
> + { PCI_VDEVICE(INTEL, 0x02aa), LPSS_CNL_SSP },
> + { PCI_VDEVICE(INTEL, 0x02ab), LPSS_CNL_SSP },
> + { PCI_VDEVICE(INTEL, 0x02fb), LPSS_CNL_SSP },
> { },
> };
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] spi: pxa2xx: Add support for Intel Comet Lake
2019-04-16 8:00 ` Andy Shevchenko
@ 2019-04-16 12:26 ` Jarkko Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2019-04-16 12:26 UTC (permalink / raw)
To: Andy Shevchenko, Evan Green
Cc: Mark Brown, Andy Shevchenko, Rajat Jain, Robert Jarzmik,
Haojian Zhuang, Linux Kernel Mailing List, linux-spi, Daniel Mack,
linux-arm Mailing List
On 4/16/19 11:00 AM, Andy Shevchenko wrote:
> On Tue, Apr 16, 2019 at 6:28 AM Evan Green <evgreen@chromium.org> wrote:
>>
>> Add PCI IDs for SPI on Comet Lake.
>>
>
> I didn't check IDs, perhaps Jarkko can do it.
> From other prospectives looks good.
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
Yes, those IDs and compatibility with Cannon Lake match with my
understanding.
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "spi: pxa2xx: Add support for Intel Comet Lake" to the spi tree
2019-04-16 3:27 [PATCH] spi: pxa2xx: Add support for Intel Comet Lake Evan Green
2019-04-16 8:00 ` Andy Shevchenko
@ 2019-04-16 16:32 ` Mark Brown
2019-05-02 2:19 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-04-16 16:32 UTC (permalink / raw)
To: Evan Green
Cc: Andy Shevchenko, Andy Shevchenko, Daniel Mack, Haojian Zhuang,
linux-arm-kernel, linux-kernel, linux-spi, Mark Brown, Rajat Jain,
Robert Jarzmik
The patch
spi: pxa2xx: Add support for Intel Comet Lake
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 5127b4d69f96793dfabb602b133dc19d1aa36880 Mon Sep 17 00:00:00 2001
From: Evan Green <evgreen@chromium.org>
Date: Mon, 15 Apr 2019 20:27:43 -0700
Subject: [PATCH] spi: pxa2xx: Add support for Intel Comet Lake
Add PCI IDs for SPI on Comet Lake.
Signed-off-by: Evan Green <evgreen@chromium.org>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-pxa2xx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 3e6811ef37e8..f5546eeaebe4 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1454,6 +1454,10 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
{ PCI_VDEVICE(INTEL, 0xa32a), LPSS_CNL_SSP },
{ PCI_VDEVICE(INTEL, 0xa32b), LPSS_CNL_SSP },
{ PCI_VDEVICE(INTEL, 0xa37b), LPSS_CNL_SSP },
+ /* CML-LP */
+ { PCI_VDEVICE(INTEL, 0x02aa), LPSS_CNL_SSP },
+ { PCI_VDEVICE(INTEL, 0x02ab), LPSS_CNL_SSP },
+ { PCI_VDEVICE(INTEL, 0x02fb), LPSS_CNL_SSP },
{ },
};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "spi: pxa2xx: Add support for Intel Comet Lake" to the spi tree
2019-04-16 3:27 [PATCH] spi: pxa2xx: Add support for Intel Comet Lake Evan Green
2019-04-16 8:00 ` Andy Shevchenko
2019-04-16 16:32 ` Applied "spi: pxa2xx: Add support for Intel Comet Lake" to the spi tree Mark Brown
@ 2019-05-02 2:19 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-05-02 2:19 UTC (permalink / raw)
To: Evan Green
Cc: Andy Shevchenko, Andy Shevchenko, Daniel Mack, Haojian Zhuang,
linux-arm-kernel, linux-kernel, linux-spi, Mark Brown, Rajat Jain,
Robert Jarzmik
The patch
spi: pxa2xx: Add support for Intel Comet Lake
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 41a918026407be4ca2727cd0d6243fe6cdbfc4ed Mon Sep 17 00:00:00 2001
From: Evan Green <evgreen@chromium.org>
Date: Mon, 15 Apr 2019 20:27:43 -0700
Subject: [PATCH] spi: pxa2xx: Add support for Intel Comet Lake
Add PCI IDs for SPI on Comet Lake.
Signed-off-by: Evan Green <evgreen@chromium.org>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-pxa2xx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 3e6811ef37e8..f5546eeaebe4 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1454,6 +1454,10 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
{ PCI_VDEVICE(INTEL, 0xa32a), LPSS_CNL_SSP },
{ PCI_VDEVICE(INTEL, 0xa32b), LPSS_CNL_SSP },
{ PCI_VDEVICE(INTEL, 0xa37b), LPSS_CNL_SSP },
+ /* CML-LP */
+ { PCI_VDEVICE(INTEL, 0x02aa), LPSS_CNL_SSP },
+ { PCI_VDEVICE(INTEL, 0x02ab), LPSS_CNL_SSP },
+ { PCI_VDEVICE(INTEL, 0x02fb), LPSS_CNL_SSP },
{ },
};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread