From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
rafael@kernel.org, Will Deacon <will.deacon@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
dri-devel@lists.freedesktop.org, Pavel Machek <pavel@ucw.cz>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-acpi@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Jiri Slaby <jslaby@suse.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Dan Murphy <dmurphy@ti.com>,
linux-usb@vger.kernel.org, Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Joe Perches <joe@perches.com>,
linux-wpan@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
David Airlie <airlied@linux.ie>,
"Rafael J . Wysocki " <rjw@rjwysocki.net>,
Thierry Reding <thierry.reding@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linu
Subject: Re: [PATCH v2 00/28] drivers: Consolidate device lookup helpers
Date: Mon, 24 Jun 2019 05:23:48 +0200 [thread overview]
Message-ID: <20190624032348.GA28919@kroah.com> (raw)
In-Reply-To: <1560534863-15115-1-git-send-email-suzuki.poulose@arm.com>
On Fri, Jun 14, 2019 at 06:53:55PM +0100, Suzuki K Poulose wrote:
> We have device iterators to find a particular device matching a criteria
> for a given bus/class/driver. i.e, {bus,class,driver}_find_device() APIs.
> The matching criteria is a function pointer for the APIs. Often the lookup
> is based on a generic property of a device (e.g, name, fwnode, of node pointer
> or device type) rather than a driver specific information. However, each driver
> writes up its own "match" function, spilling the similar match functions all
> over the driver subsystems.
>
> Additionally the prototype for the "match" functions accepted by the above APIs
> have a minute difference which prevents us otherwise sharing the match functions.
> i.e,
> int (*match)(struct device *dev, void *data) for {bus/driver}_find_device()
> vs
> int (*match)(struct device *dev, const void *) for class_find_device()
>
> If we promote the former to accept a "const void*" parameter, we could share one
> single match function for all the helpers. This series achieves the following:
>
> a) [Patches 03-05] Unify the prototype for "match" functions accepted by the
> device lookup APIs.
I've applied the first 6 patches of this series to my tree now. Let's
see how that goes, and this should give you a more solid base to redo
the rest of the series off of.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-06-24 3:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 17:53 [PATCH v2 00/28] drivers: Consolidate device lookup helpers Suzuki K Poulose
2019-06-14 17:54 ` [PATCH v2 06/28] drivers: Add generic helper to match by of_node Suzuki K Poulose
2019-06-14 20:31 ` Wolfram Sang
2019-06-17 9:59 ` Suzuki K Poulose
2019-06-17 10:06 ` Wolfram Sang
2019-06-14 17:54 ` [PATCH v2 09/28] drivers: Add generic match helper by ACPI_COMPANION device Suzuki K Poulose
2019-06-17 22:07 ` Rafael J. Wysocki
2019-06-18 8:38 ` Suzuki K Poulose
2019-06-18 8:40 ` Rafael J. Wysocki
2019-06-14 17:54 ` [PATCH v2 17/28] drivers: Introduce bus_find_device_by_of_node() helper Suzuki K Poulose
2019-06-14 20:32 ` Wolfram Sang
2019-07-09 16:19 ` Rob Herring
2019-06-24 3:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624032348.GA28919@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=dledford@redhat.com \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shyam-sundar.s-k@amd.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stefan@datenfreihafen.org \
--cc=suzuki.poulose@arm.com \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tomas.winkler@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).