Re: [PATCH v3 0/7] drivers: Add generic device lookup helpers

From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexander Aring <alex.aring@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	rafael@kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-fpga@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	dri-devel@lists.freedesktop.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Elie Morisse <syniurge@gmail.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	linux-i2c@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
	Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-acpi@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
	Lee Jones <lee.jo
Subject: Re: [PATCH v3 0/7] drivers: Add generic device lookup helpers
Date: Thu, 25 Jul 2019 16:10:36 +0200	[thread overview]
Message-ID: <20190725141036.GA14950@kroah.com> (raw)
In-Reply-To: <20190723221838.12024-1-suzuki.poulose@arm.com>

On Tue, Jul 23, 2019 at 11:18:31PM +0100, Suzuki K Poulose wrote:
> We have device iterators to find a particular device matching a criteria
> for a given bus/class/driver. i.e, {bus,class,driver}_find_device()
> APIs. The matching criteria is a function pointer for the APIs. Often the
> lookup is based on a generic property of a device (e.g, name, fwnode, of node
> pointer or device type) rather than a driver specific information. However, each
> driver writes up its own "match" function, spilling the similar match functions
> all over the driver subsystems.
> 
> This series adds device match helpers by generic device properties of a device.
> Using these generic match functions, introduce wrappers to the existing
>  *_find_device() helpers and converts the existing users to use the new wrappers.
>  i.e,
> 	{bus/class/driver}_find_device_by_name()
> 	{bus/class/driver}_find_device_by_fwnode()
> 	{bus/class/driver}_find_device_by_devt()
> 	{bus/class/driver}_find_device_by_acpi_dev()
> 
> Also adds a wrapper for finding a platform device by driver, to avoid
> spilling the platform_bus internals in the individual drivers. Applies
> on 5.3-rc1.
> 
>    [0] git://linux-arm.org/linux-skp.git driver-cleanup/v3
> RFC[1] https://marc.info/?i=1559577023-558-1-git-send-email-suzuki.poulose@arm.com
> V1 [2] https://marc.info/?i=1559747630-28065-1-git-send-email-suzuki.poulose@arm.com
> V2 [3] https://marc.info/?i=1560534863-15115-1-git-send-email-suzuki.poulose@arm.com
> 
> Changes since v2:
>  - Merge the device match helper introduction patch with the variants
>    of the helpers, for better review.
>  - Use platform_find_device_by_driver for mcde drm driver.

This looks good to me at first glance, thanks for doing this work.

I'll wait a few days to collect acks from various subsystem maintainers
before taking the series in my tree.

thanks,

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel