From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 11/36] ARM: s5pv210: split from plat-samsung Date: Fri, 11 Oct 2019 07:51:49 +0200 Message-ID: <20191011055149.4dudr4tk2znpt65u@pengutronix.de> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-11-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Ulf Hansson , Liam Girdwood , linus.walleij@linaro.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Thierry Reding , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Kukjin Kim , =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= , linux-serial@vger.kernel.org, Jiri Slaby , linux-pwm@vger.kernel.org, Bartlomiej Zolnierkiewicz , Sascha Hauer , Mark Brown , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Sangbeom Kim , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Takashi Iwai Return-path: Content-Disposition: inline In-Reply-To: <20191010203043.1241612-11-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On Thu, Oct 10, 2019 at 10:29:55PM +0200, Arnd Bergmann wrote: > These can be build completely independently, so split > the two Kconfig symbols. > = > Signed-off-by: Arnd Bergmann I'd mention the two symbols' names you're working on in the commit log. I guess it's about PLAT_SAMSUNG and ARCH_S5PV210. And I wouldn't call it "split" which IMHO suggests there was only one symbol before. Maybe: Don't imply PLAT_SAMSUNG if ARCH_S5PV210 is enabled would be a better subject line? > --- > arch/arm/Kconfig.debug | 6 +++--- > arch/arm/Makefile | 1 - > arch/arm/plat-samsung/Kconfig | 2 +- > drivers/mmc/host/Kconfig | 2 +- > drivers/pwm/Kconfig | 2 +- > drivers/spi/Kconfig | 2 +- > drivers/tty/serial/Kconfig | 2 +- > sound/soc/samsung/Kconfig | 2 +- > 8 files changed, 9 insertions(+), 10 deletions(-) > = > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 9c4f2d6deb06..4c4e97ae4fcb 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -998,7 +998,7 @@ choice > via SCIFA4 on Renesas SH-Mobile AG5 (SH73A0). > = > config DEBUG_S3C_UART0 > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS > select DEBUG_EXYNOS_UART if ARCH_EXYNOS > select DEBUG_S3C24XX_UART if ARCH_S3C24XX > select DEBUG_S3C64XX_UART if ARCH_S3C64XX > @@ -1010,7 +1010,7 @@ choice > by the boot-loader before use. > = > config DEBUG_S3C_UART1 > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS > select DEBUG_EXYNOS_UART if ARCH_EXYNOS > select DEBUG_S3C24XX_UART if ARCH_S3C24XX > select DEBUG_S3C64XX_UART if ARCH_S3C64XX > @@ -1022,7 +1022,7 @@ choice > by the boot-loader before use. > = > config DEBUG_S3C_UART2 > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS > select DEBUG_EXYNOS_UART if ARCH_EXYNOS > select DEBUG_S3C24XX_UART if ARCH_S3C24XX > select DEBUG_S3C64XX_UART if ARCH_S3C64XX > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index f492d7c338fe..a1bc15cda751 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -235,7 +235,6 @@ machine-$(CONFIG_PLAT_SPEAR) +=3D spear > # by CONFIG_* macro name. > plat-$(CONFIG_ARCH_OMAP) +=3D omap > plat-$(CONFIG_ARCH_S3C64XX) +=3D samsung > -plat-$(CONFIG_ARCH_S5PV210) +=3D samsung Would it make more sense to make this plat-$(PLAT_SAMSUNG) +=3D samsung (in a separate patch)? Hmm, it seems there is no plat-y for PLAT_S3C24XX=3Dy builds. Is this intended? If yes, the directory name containing "samsung" suggests something that seems untrue. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ |