From: Mark Brown <broonie@kernel.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-spi@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sam Ravnborg <sam@ravnborg.org>, Daniel Mack <daniel@zonque.org>,
David Lechner <david@lechnology.com>
Subject: Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()
Date: Wed, 16 Oct 2019 19:00:21 +0100 [thread overview]
Message-ID: <20191016180021.GF4881@sirena.co.uk> (raw)
In-Reply-To: <CAKMK7uEp39uvLtgyTTj31u-GYVoPiVJDTVbUThtn7NU_EoKk3A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1039 bytes --]
On Wed, Oct 16, 2019 at 07:44:51PM +0200, Daniel Vetter wrote:
> On Wed, Oct 16, 2019 at 6:13 PM Andy Shevchenko
> > On Tue, Oct 15, 2019 at 05:57:20PM +0200, Daniel Vetter wrote:
> > > Something like this, as a test patch.
> > max_transfer_size should be a function. In that case it works.
> Why do you want to make it a function? At least from my reading of the
> code, the dma vs pio decision seems to be done once. So no need to
> change this at runtime. Changing at runtime would also be a pretty big
> surprise I think for users of spi.
Yeah, I'd expect it to be a fixed property of the hardware that doesn't
vary at runtime though I'm sure there must be some innovation out there
which challenges that assumption.
> > However I'm not sure it's the best approach, thus, Cc to SPI PXA people.
> Hm didn't spot the pxa people, added them. Mark, should I just go
> ahead and bake this into a proper patch for discussion? Or
> fundamentally wrong approach?
That seems sensible enough, it should certainly fix the immediate issue.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-16 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190719155916.62465-1-noralf@tronnes.org>
[not found] ` <20190719155916.62465-6-noralf@tronnes.org>
[not found] ` <20191015143236.GA5363@smile.fi.intel.com>
[not found] ` <253aec49-e51c-b35b-4e7d-53a8a948655d@tronnes.org>
[not found] ` <20191015155720.GQ11828@phenom.ffwll.local>
2019-10-16 16:13 ` [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size() Andy Shevchenko
2019-10-16 17:44 ` Daniel Vetter
2019-10-16 18:00 ` Mark Brown [this message]
2019-10-17 6:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016180021.GF4881@sirena.co.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=daniel@ffwll.ch \
--cc=daniel@zonque.org \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haojian.zhuang@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).