From: Mark Brown <broonie@kernel.org>
To: luhua xu <luhua.xu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
wsd_upstream@mediatek.com
Subject: Re: [PATCH 1/1] spi: mediatek: add power control when set_cs
Date: Thu, 24 Oct 2019 12:19:20 +0100 [thread overview]
Message-ID: <20191024111920.GE5207@sirena.co.uk> (raw)
In-Reply-To: <1571911880.4955.11.camel@mbjsdccf07>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
On Thu, Oct 24, 2019 at 06:11:20PM +0800, luhua xu wrote:
> (3)Enable spi clk in controller->set_cs callback, such as
> spi-geni-qcom.c.
> My patch works the same as (3).For mtk platform, without this
> patch, if user do spi_setup(), cs setting cannot take effect, and reg
> access violation occurs.
Other drivers having problems isn't a good reason to introduce more
drivers with problems.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-24 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 12:38 [PATCH 0/1] Add spi power control when set cs Luhua Xu
[not found] ` <1571834322-1121-1-git-send-email-luhua.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-10-23 12:38 ` [PATCH 1/1] spi: mediatek: add power control when set_cs Luhua Xu
2019-10-23 15:11 ` Mark Brown
2019-10-24 6:25 ` luhua xu
2019-10-24 10:11 ` luhua xu
2019-10-24 11:19 ` Mark Brown [this message]
2019-10-24 10:23 ` Mark Brown
2019-10-23 15:11 ` [PATCH 0/1] Add spi power control when set cs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024111920.GE5207@sirena.co.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=luhua.xu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).