From: Mark Brown <broonie@kernel.org>
To: "wuxu.wu" <wuxu.wu@huawei.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
hushiyuan@huawei.com
Subject: Re: [PATCH] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls
Date: Tue, 31 Dec 2019 00:29:28 +0000 [thread overview]
Message-ID: <20191231002928.GD3897@sirena.org.uk> (raw)
In-Reply-To: <1577418669-34821-1-git-send-email-wuxu.wu@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
On Fri, Dec 27, 2019 at 11:51:09AM +0800, wuxu.wu wrote:
> static void dw_writer(struct dw_spi *dws)
> {
> - u32 max = tx_max(dws);
> + u32 max
> u16 txw = 0;
This is going to break the build, there's a missing ; in the
declaration of max. Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next parent reply other threads:[~2019-12-31 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1577418669-34821-1-git-send-email-wuxu.wu@huawei.com>
2019-12-31 0:29 ` Mark Brown [this message]
[not found] <1576900099-40754-1-git-send-email-wuxu.wu@huawei.com>
2019-12-27 0:50 ` [PATCH] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls Mark Brown
[not found] <1576767380-12947-1-git-send-email-wuxu.wu@huawei.com>
2019-12-19 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231002928.GD3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hushiyuan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wuxu.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).