From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v3 4/7] dt-bindings: atmel-usart: remove wildcard Date: Tue, 14 Jan 2020 12:17:04 +0100 Message-ID: <20200114111704.GN3137@piout.net> References: <1578997397-23165-1-git-send-email-claudiu.beznea@microchip.com> <1578997397-23165-5-git-send-email-claudiu.beznea@microchip.com> <20200114104237.GM3137@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, Nicolas.Ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org, Ludovic.Desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org, radu_nicolae.pirea-8LCfxC+Vs8U@public.gmane.org, richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Claudiu.Beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org On 14/01/2020 11:10:14+0000, Claudiu.Beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org wrote: > > > On 14.01.2020 12:42, Alexandre Belloni wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On 14/01/2020 12:23:14+0200, Claudiu Beznea wrote: > >> Remove chip whildcard and introduce the list of compatibles instead. > >> > >> Signed-off-by: Claudiu Beznea > >> --- > >> Documentation/devicetree/bindings/mfd/atmel-usart.txt | 7 +++---- > >> 1 file changed, 3 insertions(+), 4 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/atmel-usart.txt b/Documentation/devicetree/bindings/mfd/atmel-usart.txt > >> index 699fd3c9ace8..778e8310606a 100644 > >> --- a/Documentation/devicetree/bindings/mfd/atmel-usart.txt > >> +++ b/Documentation/devicetree/bindings/mfd/atmel-usart.txt > >> @@ -1,10 +1,9 @@ > >> * Atmel Universal Synchronous Asynchronous Receiver/Transmitter (USART) > >> > >> Required properties for USART: > >> -- compatible: Should be "atmel,-usart" or "atmel,-dbgu" > >> - The compatible indicated will be the first SoC to support an > >> - additional mode or an USART new feature. > >> - For the dbgu UART, use "atmel,-dbgu", "atmel,-usart" > >> +- compatible: Should be one of the following: > >> + - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart" > >> + - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart" > > > > All the uarts are not dbgus, so this need to be: > > > > - "atmel,at91rm9200-usart" > > - "atmel,at91sam9260-usart" > > - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart" > > - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart" > > Ok! > > > > > Also, you need to update drivers/soc/atmel/soc.c > > OK. Did you refer to CIDR, EXID registers? They are at the same offsets as > for the old products. So we can rely on old compatible for them. Is this OK? > Then, what is the point of adding microchip,sam9x60-dbgu ? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com