From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Date: Tue, 25 Feb 2020 11:31:37 -0600 Message-ID: <20200225173137.GA31830@bogus> References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Brown , linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Rutland , Matthias Brugger , linux-arm-kernel@lists.infradead.org, open list To: Chuanhong Guo Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Thu, Feb 20, 2020 at 07:58:06AM +0800, Chuanhong Guo wrote: > Hi! > > On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > > This is an ABI break so you shouldn't be doing this, if the existing > > binding works it should continue to work. > > The missing spi-max-frequency is the only part preventing old > device tree to work with this driver. > If the goal is to make existing dt binding work, I could patch dt using > of_add_property in v2. I saw similar device tree patching for legacy > bindings in pinctrl-single driver. You should should really only need 'spi-max-frequency' if the max freq is less than the minimum of the host and device max freq. Rob