From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>, Han Xu <han.xu@nxp.com>,
Adam Ford <aford173@gmail.com>,
Ashish Kumar <ashish.kumar@nxp.com>,
linux-spi <linux-spi@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: spi-nxp-fspi: Fix a NULL vs IS_ERR() check in probe
Date: Thu, 12 Mar 2020 12:18:16 +0000 [thread overview]
Message-ID: <20200312121816.GC4038@sirena.org.uk> (raw)
In-Reply-To: <CAOMZO5CJ7G7yJZEEPfsm1P2SnrJ7kmOPmZCWiKwrvDZjPNOnWw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Thu, Mar 12, 2020 at 09:11:44AM -0300, Fabio Estevam wrote:
> On Thu, Mar 12, 2020 at 8:33 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The commit message for commit d166a73503ef ("spi: fspi: dynamically
> > alloc AHB memory") is not very good. Why is it necessary to allocate
> > the AHB memory dynamically instead of during probe? Also I suspect that
> Agreed and I made the same comment during review:
> https://patchwork.kernel.org/patch/11361581/
Indeed. There had been an earlier discussion of what it was doing IIRC
but it didn't make it's way into the changelog.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-12 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 11:31 [PATCH] spi: spi-nxp-fspi: Fix a NULL vs IS_ERR() check in probe Dan Carpenter
2020-03-12 11:58 ` Adam Ford
[not found] ` <CAHCN7xKSc7spZyq=mySWHDmSrGMkQo8FYRbn-NzYRa7iB-0BoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-03-12 17:47 ` Dan Carpenter
2020-03-12 12:11 ` Fabio Estevam
2020-03-12 12:18 ` Mark Brown [this message]
[not found] ` <VI1PR04MB4015D509DC78B0C7EA649CC995FA0@VI1PR04MB4015.eurprd04.prod.outlook.com>
2020-03-13 11:54 ` [EXT] " Mark Brown
2020-03-12 16:52 ` Applied "spi: spi-nxp-fspi: Fix a NULL vs IS_ERR() check in probe" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312121816.GC4038@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aford173@gmail.com \
--cc=ashish.kumar@nxp.com \
--cc=dan.carpenter@oracle.com \
--cc=festevam@gmail.com \
--cc=han.xu@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).