From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] spi: spi-nxp-fspi: Fix a NULL vs IS_ERR() check in probe Date: Thu, 12 Mar 2020 20:47:41 +0300 Message-ID: <20200312125016.GF11583@kadam> References: <20200312113154.GC20562@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Yogesh Gaur , Han Xu , Ashish Kumar , Mark Brown , linux-spi , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Adam Ford Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, Mar 12, 2020 at 06:58:31AM -0500, Adam Ford wrote: > On Thu, Mar 12, 2020 at 6:32 AM Dan Carpenter wrote: > > > > The platform_get_resource_byname() function returns NULL on error, it > > doesn't return error pointers. > > > > Fixes: d166a73503ef ("spi: fspi: dynamically alloc AHB memory") > > Signed-off-by: Dan Carpenter > > --- > > The commit message for commit d166a73503ef ("spi: fspi: dynamically > > alloc AHB memory") is not very good. Why is it necessary to allocate > > the AHB memory dynamically instead of during probe? Also I suspect that > > Adam should have recieved authorship credit for that patch. > > It wasn't my patch, I just pulled it in from NXP's repo. The true > author is Han Xu. When I pulled in the series from NXP, I found the > flexSPI on the i.MX8MM to become functional, and my company has a > board with a qspi flash on it. You should have put your Signed-off-by after Han Xu's. They should be in chronological order so whoever handles a patch adds their S-o-b to the end. regards, dan carpenter