* [PATCH 2/2] spi: atmel: Add missing annotation for atmel_spi_next_xfer_dma_submit()
[not found] ` <20200429225723.31258-1-jbi.octave@gmail.com>
@ 2020-04-29 22:57 ` Jules Irenge
0 siblings, 0 replies; only message in thread
From: Jules Irenge @ 2020-04-29 22:57 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arm-kernel, netdev, Nicolas Ferre, Mark Brown,
Alexandre Belloni, Ludovic Desroches, open list:SPI SUBSYSTEM
Sparse reports a warning at atmel_spi_next_xfer_dma_submit()
warning: context imbalance in atmel_spi_next_xfer_dma_submit()
- unexpected unlock
The root cause is the missing annotation
at atmel_spi_next_xfer_dma_submit()
Add the missing __must_hold(&as->lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/spi/spi-atmel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 013458cabe3c..57ee8c3b7972 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -706,6 +706,7 @@ static void atmel_spi_next_xfer_pio(struct spi_master *master,
static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
struct spi_transfer *xfer,
u32 *plen)
+ __must_hold(&as->lock)
{
struct atmel_spi *as = spi_master_get_devdata(master);
struct dma_chan *rxchan = master->dma_rx;
--
2.26.2
^ permalink raw reply related [flat|nested] only message in thread