From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538ACC433E0 for ; Tue, 2 Jun 2020 09:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 278E920734 for ; Tue, 2 Jun 2020 09:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591091391; bh=7Cy56Bnu1NcpQ7UwmRjSTV/5jRN6OIJUxT52J5jFI6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Fx7DhIoVNK1N0op2x/KXM9Pgj+0uQcZdqo7YVmUR2x6Oavqcs3fELQ8WYge1sZ5vH Im7AE17p3Hc7XMg5Zqj28fY4VDvTiUrTS5538oL1d0VKr3oDP9Btzu5ChDcbsCS/jZ cDMrlf6lYrr8Hd2obOCtzLb421V11V9njzHI8WqU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbgFBJtu (ORCPT ); Tue, 2 Jun 2020 05:49:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:47204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbgFBJtu (ORCPT ); Tue, 2 Jun 2020 05:49:50 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8582920679; Tue, 2 Jun 2020 09:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591091390; bh=7Cy56Bnu1NcpQ7UwmRjSTV/5jRN6OIJUxT52J5jFI6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cu0Rsuf7AbaiYX/J0nYfTDJppwK7y9QMiRWWqXdUSp7obOlFCpFRX7WjOpRrg1ZXT IMNiU6fo0dE5j/Zy4eYOZNY+1y81uZ9CQK3im/EkG7f1PIXMhOaggrZfCMjGhllpiz 1w8GZdefBEVvpa7pLvHT8dEASWG2vhOojvkdRsEY= Date: Tue, 2 Jun 2020 10:49:47 +0100 From: Mark Brown To: Markus Elfring Cc: Navid Emamdoost , linux-spi@vger.kernel.org, Navid Emamdoost , Kangjie Lu , Stephen McCamant , Qiushi Wu , Dinghao Liu , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure Message-ID: <20200602094947.GA5684@sirena.org.uk> References: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de> X-Cookie: We are not a clone. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 02, 2020 at 10:40:33AM +0200, Markus Elfring wrote: > > The counter is incremented via pm_runtime_get even in failure case. > > To correct the counter call pm_runtime_put in case of failure, too. >=20 > How do you think about a wording variant like the following? >=20 > Change description: > The PM runtime reference counter is generally incremented by a call of > the function =E2=80=9Cpm_runtime_get_sync=E2=80=9D. > Thus call the function =E2=80=9Cpm_runtime_put_autosuspend=E2=80=9D al= so in one error case > to keep the reference counting consistent. The original changelog is perfectly fine, please stop sending these. --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7WILoACgkQJNaLcl1U h9DjBAf8Cv2mppt2k43MzqHRc3jstaRWync9NLGQlJhGTT7Y3mPwynIc64JoOPKk n88vwec+oBWDCnFUZZzNT7eK3XYJNFvnC10mt0p8kZSYu1wznntH/lBA8FNMu7Qy varbbXp5irF+x1VyKfc3phJG/s7Gi5jnixtv/MZcEBY84GroD4nXvwlmIWzPrhxo EJEAVd2F4Eea5n7p9ivEDRacCkP7G/2jYTYjWdfW6JYkJVpLgJdH6xzuD3cWZjIb KkXT4EbKlh/6F6oOuutwsc0tRHG++YeOVAGNbqtSrpELbzOx9e8v4qeSedSzAxta Bx995z3ICwchSCLdLMZWqRI44gr4ow== =l1jf -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--