From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6210C433E0 for ; Tue, 2 Jun 2020 18:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98F6F20734 for ; Tue, 2 Jun 2020 18:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591123007; bh=OvQjdPoM0pJTu54sJl+ffqQUAsF4t+qMSrZonGhfXr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZR8so7p3eRzPNSyiX1XwD8l5g8Y2sMqCehgAzD9h9oH9GFfJYd2BQsL5YmmbZ1HeP i04rl6Qd09PP1pSubc8KhWMGH7i9Ylz8Vmww0ETfSiNVAignsFeAHnKoDobB4ZTpwy imuVYUShXwxPUigB4mRsJfrddMS+4sJI7BTDqV6s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbgFBSgr (ORCPT ); Tue, 2 Jun 2020 14:36:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:47670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726728AbgFBSgr (ORCPT ); Tue, 2 Jun 2020 14:36:47 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C6442072F; Tue, 2 Jun 2020 18:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591123006; bh=OvQjdPoM0pJTu54sJl+ffqQUAsF4t+qMSrZonGhfXr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UWuBRQkdY99dlKdSFTzfrSniB90bkr6VieoRYdv07lD+xXNP5vH7xP+znRdvLtssc uMUJrCLfVqLgFEtdsG7glA6raTtaA3V0uJPcsZPHI8i+cu5RBw8I4p2mpnTsTlPFvF 6fokw5AX6dpDFXEYJxF79iaFpQ6VG1N82Qoz99/k= Date: Tue, 2 Jun 2020 19:36:44 +0100 From: Mark Brown To: Markus Elfring Cc: Navid Emamdoost , linux-spi@vger.kernel.org, Navid Emamdoost , Kangjie Lu , Stephen McCamant , Qiushi Wu , Dinghao Liu , LKML , kernel-janitors@vger.kernel.org Subject: Re: spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure Message-ID: <20200602183644.GI5684@sirena.org.uk> References: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de> <20200602094947.GA5684@sirena.org.uk> <1c13e0ec-e50f-9eea-5704-052d2d682727@web.de> <20200602141306.GH5684@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N8NGGaQn1mzfvaPg" Content-Disposition: inline In-Reply-To: X-Cookie: We are not a clone. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --N8NGGaQn1mzfvaPg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 02, 2020 at 05:05:18PM +0200, Markus Elfring wrote: > >> I find this commit message improvable also according to Linux software > >> development documentation. > > Causing people to send out new versions of things for tweaks to the > > commit log consumes time for them and everyone they're sending changes to. > Improving patches (besides source code adjustments) is an usual software > development activity, isn't it? Your updates were not improvements. The formatting was worse and to my native speaker eyes the grammar was worse. With this sort of stylistic thing it's especially important that any review aligns with the needs and practices of the subsystem, there is opinion in there and multiple opinions just makes things harder for submitters. --N8NGGaQn1mzfvaPg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7WnDsACgkQJNaLcl1U h9DGkAf+PjSEqHTfl5f2iz9hfmR2SynpiykJ1XkuI/QQI+g5b8po5GEO+Ex48irJ eZapYj6s73KBN1FcvTkmGNrCqO1sGQwMXvsf0cIQ1gFltQt01hopOWwqGvt1MtDm nwCi6sU1jOjGzkQ/sgxvvIPIz8YAQ+YD177k4v6XKma565eJGukVTpQZfwWi52Xq MHT93raV0bDM1nZz2/xe/P1GsKd4iO/+nGbI2qA9ZmueqGzbsqphOlgf1Z/M4em2 qIA7qVs5WkjL01yyBjwoKkZo1Q7XVp20NtZvytXut/iFx0X4XUV2E/ehB/EqAcKt REEO3WfKi8oLPVWCRSzau202uix/yQ== =NOcb -----END PGP SIGNATURE----- --N8NGGaQn1mzfvaPg--