RE: [PATCH v1 RFC 1/2] spi: introduce fallback to pio

Robin Gong
2020-06-16T10:13:14Z

On 2020/06/16 Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote:
> > struct list_head transfer_list;
> > +
> > +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma
> failed */
> > + u16 flags;
>
> I'd just make this a generic flag for failures before we start interacting with the
> hardware rather than specifically this one error case. Otherwise this looks
> fine.
So rename to SPI_TRANS_DMA_FAIL? I think at least DMA is MUST for fallback
case...