Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio

Mark Brown
2020-06-16T09:59:51Z

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote:
> On 2020/06/15 22:56 Mark Brown <broonie@kernel.org> wrote:

> struct list_head transfer_list;
> +
> +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */
> + u16 flags;

I'd just make this a generic flag for failures before we start
interacting with the hardware rather than specifically this one error
case. Otherwise this looks fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]