From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC46C433DF for ; Mon, 15 Jun 2020 17:12:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C724420656 for ; Mon, 15 Jun 2020 17:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592241134; bh=xZw3wFFs3EiOb5XtW46JuclA2MCo7BVAfYAO895nV6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0XVW9TnFZkkaVK6raKcJo96TAr060/VE7FRTFxQOctPOvzseObUAMrDccrBsZDjI/ bYjxFZUxyWInm5m+WQ15d4rQ6WYAYTFqvb9AklWCKslqt1x1eavMTA7xb7jfRiAlqw Ad93yM8SS1BCz13Fcp+51v6qgs6t88clNDvY2xEs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731087AbgFORMO (ORCPT ); Mon, 15 Jun 2020 13:12:14 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:39766 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728585AbgFORMO (ORCPT ); Mon, 15 Jun 2020 13:12:14 -0400 Received: by mail-il1-f194.google.com with SMTP id p5so16032953ile.6; Mon, 15 Jun 2020 10:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G5WGUPUAIcBwza0/xjtURoDyzwjIEB/Wr5gpuV9swD0=; b=Fb5sDDB6HAlXnpW72K2SysMhHR6ikH+Ykhhe5p25LfdPbgbZU3KCUlvWMsslFZELKp DtMBAItYor6zb9jFTUl8fiKIltN9olwQPiklKgmBTECXNSA6PWQjru2vIiSfDztDKfbF Y+QguN10MtEVyGpCcOBLn9ujYjjq0Oj79fZsf9UFvcrv8pXQ9wJGOCIx9UJoNEc4ItOI ufeDI7+VN8iBt+daO3PbA61Ga14YuqBxrbCJOC2FMIvY7u8BK0ng8vr7b2vIQPZsYqX8 r9MiFXVYWHZci//6BEZjOKiSXf64/K2vxYbFCWNV6M3xqmW9y4oyqg7K9gNOsmJaRCKO k48A== X-Gm-Message-State: AOAM5335ITTZVqkEzSbq6JNhbwhasnj8HijusyMyXJ9ePCDn7QDuhB5E wBDsjGBN60FQFUvhUqjLmg== X-Google-Smtp-Source: ABdhPJxkSrEaxMErK0l1AP6V19vUpDxfZBbTo5MTNzsZPQNLZcHrexQ20OfNYIzpl4S1RoaRPH6/Mg== X-Received: by 2002:a92:d845:: with SMTP id h5mr27854230ilq.4.1592241131756; Mon, 15 Jun 2020 10:12:11 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id d71sm8551428ill.9.2020.06.15.10.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 10:12:11 -0700 (PDT) Received: (nullmailer pid 1970644 invoked by uid 1000); Mon, 15 Jun 2020 17:12:09 -0000 Date: Mon, 15 Jun 2020 11:12:09 -0600 From: Rob Herring To: Anson Huang Cc: broonie@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi to json-schema Message-ID: <20200615171209.GA1968084@bogus> References: <1591235731-15673-1-git-send-email-Anson.Huang@nxp.com> <1591235731-15673-2-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1591235731-15673-2-git-send-email-Anson.Huang@nxp.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Thu, Jun 04, 2020 at 09:55:29AM +0800, Anson Huang wrote: > Convert the MXS SPI binding to DT schema format using json-schema > > Signed-off-by: Anson Huang > --- > Changes since V1: > - add "unevaluatedProperties: false". > --- > Documentation/devicetree/bindings/spi/mxs-spi.txt | 26 ---------- > Documentation/devicetree/bindings/spi/mxs-spi.yaml | 57 ++++++++++++++++++++++ > 2 files changed, 57 insertions(+), 26 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt > create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt b/Documentation/devicetree/bindings/spi/mxs-spi.txt > deleted file mode 100644 > index 3499b73..0000000 > --- a/Documentation/devicetree/bindings/spi/mxs-spi.txt > +++ /dev/null > @@ -1,26 +0,0 @@ > -* Freescale MX233/MX28 SSP/SPI > - > -Required properties: > -- compatible: Should be "fsl,-spi", where soc is "imx23" or "imx28" > -- reg: Offset and length of the register set for the device > -- interrupts: Should contain SSP ERROR interrupt > -- dmas: DMA specifier, consisting of a phandle to DMA controller node > - and SSP DMA channel ID. > - Refer to dma.txt and fsl-mxs-dma.txt for details. > -- dma-names: Must be "rx-tx". > - > -Optional properties: > -- clock-frequency : Input clock frequency to the SPI block in Hz. > - Default is 160000000 Hz. > - > -Example: > - > -ssp0: ssp@80010000 { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = "fsl,imx28-spi"; > - reg = <0x80010000 0x2000>; > - interrupts = <96>; > - dmas = <&dma_apbh 0>; > - dma-names = "rx-tx"; > -}; > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.yaml b/Documentation/devicetree/bindings/spi/mxs-spi.yaml > new file mode 100644 > index 0000000..68c5d6d > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/mxs-spi.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/mxs-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale MX233/MX28 SSP/SPI > + > +maintainers: > + - Marek Vasut > + > +allOf: > + - $ref: "/schemas/spi/spi-controller.yaml#" > + > +properties: > + compatible: > + enum: > + - fsl,imx23-spi > + - fsl,imx28-spi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + dmas: > + maxItems: 1 > + > + dma-names: > + const: rx-tx > + > + clock-frequency: > + $ref: /schemas/types.yaml#/definitions/uint32 Already has a type, drop. With that, Reviewed-by: Rob Herring > + description: input clock frequency to the SPI block in Hz. > + default: 160000000 > + > +required: > + - compatible > + - reg > + - interrupts > + - dmas > + - dma-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi@80010000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx28-spi"; > + reg = <0x80010000 0x2000>; > + interrupts = <96>; > + dmas = <&dma_apbh 0>; > + dma-names = "rx-tx"; > + }; > -- > 2.7.4 >