From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DF4C433E0 for ; Tue, 16 Jun 2020 09:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FDCB2078E for ; Tue, 16 Jun 2020 09:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592301591; bh=H00RGJq5KezVcrQ/vGzLRXHsGQa2G3LnLHyCG7559QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j6lk4pfJUdLtEodaFzaZ1ny+Y0duwZiws+ILvG8wMwPEGtCFSO0lKiIjbenONRUFo uloQdGlRpfNr1ayqiDmwX6R7ItXocp/h080bW7pJz5RSjkrNJEzjrJdd2wfOsx1kKQ 7ci1nMAQFCf+xzpZpuL4F/GpT+inIxYJs79xE3/I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726099AbgFPJ7v (ORCPT ); Tue, 16 Jun 2020 05:59:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:60964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbgFPJ7u (ORCPT ); Tue, 16 Jun 2020 05:59:50 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CA0720767; Tue, 16 Jun 2020 09:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592301590; bh=H00RGJq5KezVcrQ/vGzLRXHsGQa2G3LnLHyCG7559QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s35iCxf2ApOcJZGyTnKb4vFHqFOY/SexyqbRTgxWkYLnGAD85dUn2XN6AYZkK4Yms bl62nwah75Ax2duvcU+bVe2CmlysoY32l9chot9A7Qr1u4UA5fiP/m2ZlZQO/ik3av tMj/TY1ARiyudeRqXH3l8XqEFpJspJfUFi6ej97w= Date: Tue, 16 Jun 2020 10:59:48 +0100 From: Mark Brown To: Robin Gong Cc: Vinod Koul , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robin.murphy@arm.com" , "matthias.schiffer@ew.tq-group.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200616095948.GJ4447@sirena.org.uk> References: <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> <20200615145556.GY4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6xTM0kUsJcaNctaW" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --6xTM0kUsJcaNctaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote: > On 2020/06/15 22:56 Mark Brown wrote:=20 > struct list_head transfer_list; > + > +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */ > + u16 flags; I'd just make this a generic flag for failures before we start interacting with the hardware rather than specifically this one error case. Otherwise this looks fine. --6xTM0kUsJcaNctaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7omBMACgkQJNaLcl1U h9CvpQf+Nxs8GAzGWD8q5WQ5Yfk5Dd+UDwg0tf7+zdTr05h6hiN4THe7qjTZBk6+ MC0R19TGfmpOaqHJY8nh3Nr2HY2QUv+ceTtIYVmwxpG+oE9TTE1v5WQTzOTQ5HMV yq8qU6g8Tfa1uB6BLAchJMy2lBvU/mjNqRnDY4ONnr5qkrmmKgQZycDnilH3ICEy VVS2cenoNIUooeyGwBCFOO8GnxfPhYtO3P5CLZvFPmg6OEdq0qIbluxYksdknKiR cBMORkKWR3BEZwuCx2R6xjUk17zxIpc5Km7XmjrZXSSitzONPcMjcaqVq4mtuNAU 5hztHr9mzDtIlWqoD8uLxSczu7wlVg== =AZSa -----END PGP SIGNATURE----- --6xTM0kUsJcaNctaW--