From: Mark Brown <broonie@kernel.org>
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
kuldip dwivedi <kuldip.dwivedi@puresoftware.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Tanveer Alam <tanveer.alam@puresoftware.com>
Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
Date: Wed, 26 Aug 2020 11:19:54 +0100 [thread overview]
Message-ID: <20200826101954.GD4965@sirena.org.uk> (raw)
In-Reply-To: <VE1PR04MB6768E050B97AAA33501B6D6891540@VE1PR04MB6768.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
On Wed, Aug 26, 2020 at 08:19:41AM +0000, Qiang Zhao wrote:
> On Mon, Aug 24, 2020 at 19:25, Mark Brown <broonie@kernel.org> wrote:
> > Yes, it's a legacy from bad board file conversions and shouldn't be used at all.
> I saw a lot of driver assign spi_controller -> num_chipselect directly, should we do like that?
Yes, you should know the number of chip selects based on the controller.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-26 10:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:10 [PATCH] spi: spi-fsl-dspi: Add ACPI support kuldip dwivedi
2020-08-21 14:07 ` Mark Brown
2020-08-22 14:07 ` Kuldip Dwivedi
2020-08-22 15:21 ` Vladimir Oltean
2020-08-24 11:25 ` Mark Brown
2020-08-26 8:19 ` Qiang Zhao
2020-08-26 10:19 ` Mark Brown [this message]
2020-08-26 11:10 ` Qiang Zhao
2020-08-26 11:47 ` Vladimir Oltean
2020-08-26 14:23 ` Mark Brown
2020-08-26 14:47 ` Vladimir Oltean
2020-08-26 15:13 ` Kuldip Dwivedi
2020-08-26 16:09 ` Vladimir Oltean
2020-08-26 17:02 ` Mark Brown
2020-08-26 18:30 ` Vladimir Oltean
2020-08-26 18:36 ` Mark Brown
2020-08-26 16:55 ` Mark Brown
2020-08-26 18:33 ` Vladimir Oltean
2020-08-26 18:42 ` Mark Brown
2020-08-21 16:49 ` kernel test robot
2020-08-22 18:33 ` Vladimir Oltean
2020-08-26 19:34 ` Andy Shevchenko
2020-08-26 19:36 ` Andy Shevchenko
2020-08-26 19:56 ` Vladimir Oltean
2020-08-26 20:41 ` Mark Brown
2020-08-26 20:41 ` Vladimir Oltean
2020-08-26 20:45 ` Mark Brown
2020-08-26 21:06 ` Vladimir Oltean
2020-08-27 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826101954.GD4965@sirena.org.uk \
--to=broonie@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pankaj.bansal@nxp.com \
--cc=qiang.zhao@nxp.com \
--cc=tanveer.alam@puresoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).