From: Vladimir Oltean <olteanv@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Qiang Zhao <qiang.zhao@nxp.com>,
kuldip dwivedi <kuldip.dwivedi@puresoftware.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Tanveer Alam <tanveer.alam@puresoftware.com>
Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
Date: Wed, 26 Aug 2020 21:33:38 +0300 [thread overview]
Message-ID: <20200826183338.rwacm5cstialye7p@skbuf> (raw)
In-Reply-To: <20200826165552.GK4965@sirena.org.uk>
On Wed, Aug 26, 2020 at 05:55:52PM +0100, Mark Brown wrote:
> On Wed, Aug 26, 2020 at 05:47:44PM +0300, Vladimir Oltean wrote:
> > On Wed, Aug 26, 2020 at 03:23:12PM +0100, Mark Brown wrote:
> > > On Wed, Aug 26, 2020 at 02:47:58PM +0300, Vladimir Oltean wrote:
>
> > > > { "NXP0005", .driver_data = (kernel_ulong_t)&devtype_data[LS2085A], }
>
> > > Based on some other stuff I've seen with ACPI on NXP stuff it looks like
> > > they're following the same scheme but only caring about that one SoC for
> > > the time being.
>
> > So, no argument about caring only about ACPI on one particular SoC for
> > the time being, but there's a big difference between a solution that
> > works for N=1 and one that works for N=2...
>
> > Showing my ignorance here, but is there something equivalent to
> > of_machine_is_compatible() for ACPI?
>
> The NXP0005 is the ACPI equivalent of a compatible (comprehensibility is
> not ACPI's forte) and they're tying driver data to it there.
Where I was trying to get here is that we could have a single _HID for
the DSPI controller, and corroborate that with the ACPI equivalent of
of_machine_is_compatible("fsl,ls2085a") at driver probe time before
assigning the driver data.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-08-26 18:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:10 [PATCH] spi: spi-fsl-dspi: Add ACPI support kuldip dwivedi
2020-08-21 14:07 ` Mark Brown
2020-08-22 14:07 ` Kuldip Dwivedi
2020-08-22 15:21 ` Vladimir Oltean
2020-08-24 11:25 ` Mark Brown
2020-08-26 8:19 ` Qiang Zhao
2020-08-26 10:19 ` Mark Brown
2020-08-26 11:10 ` Qiang Zhao
2020-08-26 11:47 ` Vladimir Oltean
2020-08-26 14:23 ` Mark Brown
2020-08-26 14:47 ` Vladimir Oltean
2020-08-26 15:13 ` Kuldip Dwivedi
2020-08-26 16:09 ` Vladimir Oltean
2020-08-26 17:02 ` Mark Brown
2020-08-26 18:30 ` Vladimir Oltean
2020-08-26 18:36 ` Mark Brown
2020-08-26 16:55 ` Mark Brown
2020-08-26 18:33 ` Vladimir Oltean [this message]
2020-08-26 18:42 ` Mark Brown
2020-08-21 16:49 ` kernel test robot
2020-08-22 18:33 ` Vladimir Oltean
2020-08-26 19:34 ` Andy Shevchenko
2020-08-26 19:36 ` Andy Shevchenko
2020-08-26 19:56 ` Vladimir Oltean
2020-08-26 20:41 ` Mark Brown
2020-08-26 20:41 ` Vladimir Oltean
2020-08-26 20:45 ` Mark Brown
2020-08-26 21:06 ` Vladimir Oltean
2020-08-27 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826183338.rwacm5cstialye7p@skbuf \
--to=olteanv@gmail.com \
--cc=V.Sethi@nxp.com \
--cc=broonie@kernel.org \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=qiang.zhao@nxp.com \
--cc=tanveer.alam@puresoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).