Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Gustav Wiklander <gustav.wiklander@axis.com>
Cc: linux-spi@vger.kernel.org, kernel@axis.com,
	Gustav Wiklander <gustavwi@axis.com>
Subject: Re: [PATCH] spi: Fix memory leak on splited transfers
Date: Mon, 7 Sep 2020 11:49:14 +0100	[thread overview]
Message-ID: <20200907104914.GB4907@sirena.org.uk> (raw)
In-Reply-To: <20200905201421.29495-1-gustav.wiklander@axis.com>

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Sat, Sep 05, 2020 at 10:14:21PM +0200, Gustav Wiklander wrote:
> From: Gustav Wiklander <gustavwi@axis.com>
> 
> In the prepare_message callback the bus driver has the
> opportunity to split a transfer into smaller chunks.
> spi_map_msg is done after prepare_message.

You've not included a signed-off-by so I can't do anything with this,
see submitting-patches.rst for details on what this means and why it's
important.

> [   76.611642][  T170] kmemleak: unreferenced object 0xfffffff06ef81480
> (size 128):
> [   76.618965][  T170] kmemleak:   comm "insmod", pid 493, jiffies
> 4294941102 (age 38.540s)
> [   76.627031][  T170] kmemleak:   backtrace:
> [   76.631206][  T170] kmemleak:     [<ffffffa542c5f8f8>]

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-09-07 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 20:14 [PATCH] spi: Fix memory leak on splited transfers Gustav Wiklander
2020-09-07 10:49 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907104914.GB4907@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=gustav.wiklander@axis.com \
    --cc=gustavwi@axis.com \
    --cc=kernel@axis.com \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox