From: Mark Brown <broonie@kernel.org>
To: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Cc: Ashish Kumar <ashish.kumar@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Varun Sethi <V.Sethi@nxp.com>, Arokia Samy <arokia.samy@nxp.com>
Subject: Re: [PATCH v1] spi: spi-nxp-fspi: Add ACPI support
Date: Wed, 9 Sep 2020 13:01:48 +0100 [thread overview]
Message-ID: <20200909120148.GC4926@sirena.org.uk> (raw)
In-Reply-To: <20200908060227.299-1-kuldip.dwivedi@puresoftware.com>
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
On Tue, Sep 08, 2020 at 11:32:27AM +0530, kuldip dwivedi wrote:
This appears to be v2 not v1?
> Currently NXP fspi driver has support of DT only. Adding ACPI
> support to the driver so that it can be used by UEFI firmware
> booting in ACPI mode. This driver will be probed if any firmware
> will expose HID "NXP0009" in DSDT table.
As I said on your previous version:
| Does NXP know about this ID assignment from their namespace? ACPI IDs
| should be namespaced by whoever's assigning the ID to avoid collisions.
Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed. Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing. If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.
> @@ -900,6 +910,8 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f)
> return ret;
>
> /* Reset the module */
> + fspi_writel(f, FSPI_MCR0_SWRST, (base + FSPI_MCR0));
> +
> /* w1c register, wait unit clear */
> ret = fspi_readl_poll_tout(f, f->iobase + FSPI_MCR0,
> FSPI_MCR0_SWRST, 0, POLL_TOUT, false);
Why are you adding this reset? How is it connected to adding ACPI
support - it looks like it should be a separate patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-09 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 6:02 [PATCH v1] spi: spi-nxp-fspi: Add ACPI support kuldip dwivedi
2020-09-09 11:27 ` [EXT] " Ashish Kumar
2020-09-09 14:17 ` Kuldip Dwivedi
2020-09-09 12:01 ` Mark Brown [this message]
2020-09-09 12:59 ` Kuldip Dwivedi
2020-09-09 14:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909120148.GC4926@sirena.org.uk \
--to=broonie@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=arokia.samy@nxp.com \
--cc=ashish.kumar@nxp.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).