From: Mark Brown <broonie@kernel.org>
To: Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>
Cc: Ashish Kumar <ashish.kumar@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Varun Sethi <V.Sethi@nxp.com>, Arokia Samy <arokia.samy@nxp.com>
Subject: Re: [PATCH v1] spi: spi-nxp-fspi: Add ACPI support
Date: Wed, 9 Sep 2020 15:32:06 +0100 [thread overview]
Message-ID: <20200909143206.GD4926@sirena.org.uk> (raw)
In-Reply-To: <af06cac916ebcdf6f526baa9cba98494@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
On Wed, Sep 09, 2020 at 06:29:10PM +0530, Kuldip Dwivedi wrote:
> > | Does NXP know about this ID assignment from their namespace? ACPI IDs
> > | should be namespaced by whoever's assigning the ID to avoid
> collisions.
> Yes, NXP is aware.
Can anyone from NXP confirm this?
> > Please don't ignore review comments, people are generally making them
> for a
> > reason and are likely to have the same concerns if issues remain
> This is new Patch for different IP (FSPI) and scenario is different from
> DSPI driver.
If a generic issue like this exists with one patch you should expect
that exactly the same issue is going to come up with other very similar
patches and therefore ensure they are addressed so people don't feel
like you are ignoring them.
> > > /* Reset the module */
> > > + fspi_writel(f, FSPI_MCR0_SWRST, (base + FSPI_MCR0));
> > > +
> > Why are you adding this reset? How is it connected to adding ACPI
> support - it
> > looks like it should be a separate patch.
> I observed a kernel panic in setting up the driver, and this fixed the
> issue.
At the very least this would need to be called out in the changelog but
like I say it should really be a separate patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-09 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 6:02 [PATCH v1] spi: spi-nxp-fspi: Add ACPI support kuldip dwivedi
2020-09-09 11:27 ` [EXT] " Ashish Kumar
2020-09-09 14:17 ` Kuldip Dwivedi
2020-09-09 12:01 ` Mark Brown
2020-09-09 12:59 ` Kuldip Dwivedi
2020-09-09 14:32 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909143206.GD4926@sirena.org.uk \
--to=broonie@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=arokia.samy@nxp.com \
--cc=ashish.kumar@nxp.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).