From: Eddie James <eajames@linux.ibm.com>
To: linux-spi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
joel@jms.id.au, broonie@kernel.org, bradleyb@fuzziesquirrel.com,
robh+dt@kernel.org, arnd@arndb.de, eajames@linux.ibm.com
Subject: [PATCH v2 1/6] spi: fsi: Handle 9 to 15 byte transfers lengths
Date: Wed, 9 Sep 2020 17:28:52 -0500 [thread overview]
Message-ID: <20200909222857.28653-2-eajames@linux.ibm.com> (raw)
In-Reply-To: <20200909222857.28653-1-eajames@linux.ibm.com>
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
The trailing <len> - 8 bytes of transfer data in this size range is no
longer ignored.
Fixes: bbb6b2f9865b ("spi: Add FSI-attached SPI controller driver")
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/spi/spi-fsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c
index 37a3e0f8e752..8f64af0140e0 100644
--- a/drivers/spi/spi-fsi.c
+++ b/drivers/spi/spi-fsi.c
@@ -258,15 +258,15 @@ static int fsi_spi_sequence_transfer(struct fsi_spi *ctx,
if (loops > 1) {
fsi_spi_sequence_add(seq, SPI_FSI_SEQUENCE_BRANCH(idx));
- if (rem)
- fsi_spi_sequence_add(seq, rem);
-
rc = fsi_spi_write_reg(ctx, SPI_FSI_COUNTER_CFG,
SPI_FSI_COUNTER_CFG_LOOPS(loops - 1));
if (rc)
return rc;
}
+ if (rem)
+ fsi_spi_sequence_add(seq, rem);
+
return 0;
}
--
2.26.2
next prev parent reply other threads:[~2020-09-09 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 22:28 [PATCH v2 0/6] spi: Fixes for FSI-attached controller Eddie James
2020-09-09 22:28 ` Eddie James [this message]
2020-09-09 22:28 ` [PATCH v2 2/6] spi: fsi: Fix clock running too fast Eddie James
2020-09-09 22:28 ` [PATCH v2 3/6] spi: fsi: Fix use of the bneq+ sequencer instruction Eddie James
2020-09-09 22:28 ` [PATCH v2 4/6] dt-bindings: fsi: fsi2spi: Add compatible string for restricted version Eddie James
2020-09-09 22:28 ` [PATCH v2 5/6] spi: fsi: Implement restricted size for certain controllers Eddie James
2020-09-09 22:28 ` [PATCH v2 6/6] spi: fsi: Check mux status before transfers Eddie James
2020-09-17 18:58 ` [PATCH v2 0/6] spi: Fixes for FSI-attached controller Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909222857.28653-2-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=bradleyb@fuzziesquirrel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).