From: Mark Brown <broonie@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>, linux-spi@vger.kernel.org
Subject: Re: users of spi_unregister_controller() broken?
Date: Tue, 22 Sep 2020 12:22:41 +0100 [thread overview]
Message-ID: <20200922112241.GO4792@sirena.org.uk> (raw)
In-Reply-To: <20200922100715.yxu55etwq64pry4n@skbuf>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Tue, Sep 22, 2020 at 01:07:15PM +0300, Vladimir Oltean wrote:
> Does it help if you call spi_controller_get(dspi->ctlr) at the beginning
> of dspi_remove, and spi_controller_put(dspi->ctlr) at the end of it?
That'd be another way to do it but TBH it feels pretty contorted. Just
allocating separate driver data seems a lot less trouble, or taking
copies of fields that are needed to clean up before freeing the
controller.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-22 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 11:08 users of spi_unregister_controller() broken? Sascha Hauer
2020-09-21 12:00 ` Mark Brown
2020-09-22 10:07 ` Vladimir Oltean
2020-09-22 11:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922112241.GO4792@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox