From: Mark Brown <broonie@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Cheng-Jui.Wang@mediatek.com, kernel-team@android.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
clang-built-linux@googlegroups.com,
Daniel Mentz <danielmentz@google.com>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v1 2/2] spi: Populate fwnode in of_register_spi_device()
Date: Thu, 5 Nov 2020 17:12:01 +0000 [thread overview]
Message-ID: <20201105171201.GF4856@sirena.org.uk> (raw)
In-Reply-To: <20201104205431.3795207-2-saravanak@google.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Wed, Nov 04, 2020 at 12:54:31PM -0800, Saravana Kannan wrote:
> From: Daniel Mentz <danielmentz@google.com>
>
> This allows the fw_devlink feature to work for spi devices
> too. This avoids unnecessary probe deferrals related to spi devices and
> improves suspend/resume ordering for spi devices when fw_devlink=on.
> of_node_get(nc);
> spi->dev.of_node = nc;
> + spi->dev.fwnode = of_fwnode_handle(nc);
Why is this a manual step in an individual subsystem rather than
something done in the driver core - when would we not want to have the
fwnode correspond to the of_node, and wouldn't that just be a case of
checking to see if there is a fwnode already set and only initializing
if not anyway?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-05 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201104205431.3795207-1-saravanak@google.com>
2020-11-04 20:54 ` [PATCH v1 2/2] spi: Populate fwnode in of_register_spi_device() Saravana Kannan
2020-11-05 17:12 ` Mark Brown [this message]
2020-11-05 19:26 ` Saravana Kannan
2020-11-06 15:10 ` Mark Brown
2020-11-06 19:12 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105171201.GF4856@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Cheng-Jui.Wang@mediatek.com \
--cc=clang-built-linux@googlegroups.com \
--cc=danielmentz@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).