From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD67C2D0A3 for ; Fri, 6 Nov 2020 08:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F65D20A8B for ; Fri, 6 Nov 2020 08:34:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="c79gTtiU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbgKFIeC (ORCPT ); Fri, 6 Nov 2020 03:34:02 -0500 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:43176 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbgKFIeC (ORCPT ); Fri, 6 Nov 2020 03:34:02 -0500 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A68S9GS003573; Fri, 6 Nov 2020 09:33:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=STMicroelectronics; bh=a335JwVUPK1cFyrEFD0jZvrG1Powtrjh0dqnCUL5i08=; b=c79gTtiUTFeHfJll+DvYix9m9t9PfQVpwh8VJhYAor4xs69hJkeQbgLkxIfiXL+Jru7B ABCkyFIqwP8iHAXVEU4jE/EKDaXEl5nf+t/tvm5HgSnm3dThvjYyPWqR4QvrHygFozKF sO/ZRfE7JqViulsHMqxAI9CQBm++4akZifS54gAgz5mFODrZKL9TVtcOeFcpjDljhQoE gtec/OoHlnnZo/JJZ5THIO6eE0QlIUqmpK/3LW3NR7DbxP77uVWzWP2hBnFw3rAtInLa HE0MGwuhj5DObxGU3SFuPr5f7/DnWG9Riuu90nbmfWnKeuULAaXwE2IU27fhYavqhzHh lw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 34h00etynj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Nov 2020 09:33:46 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6099310002A; Fri, 6 Nov 2020 09:33:45 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 4E33A22C216; Fri, 6 Nov 2020 09:33:45 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.46) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov 2020 09:32:52 +0100 Date: Fri, 6 Nov 2020 09:32:47 +0100 From: Alain Volmat To: Zhang Qilong CC: , , , , , Subject: Re: [PATCH] spi: stm32: fix reference leak in stm32_spi_resume Message-ID: <20201106083247.GA9484@gnbcxd0016.gnb.st.com> Mail-Followup-To: Zhang Qilong , broonie@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20201106015217.140476-1-zhangqilong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201106015217.140476-1-zhangqilong3@huawei.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG3NODE3.st.com (10.75.127.9) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-06_03:2020-11-05,2020-11-06 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Zhang, thanks for the patch. Reviewed-by: Alain Volmat Alain On Fri, Nov 06, 2020 at 09:52:17AM +0800, Zhang Qilong wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to pm_runtime_put_noidle will result in > reference leak in stm32_spi_resume, so we should fix it. > > Fixes: db96bf976a4fc ("spi: stm32: fixes suspend/resume management") > Signed-off-by: Zhang Qilong > --- > drivers/spi/spi-stm32.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c > index 2cc850eb8922..471dedf3d339 100644 > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -2062,6 +2062,7 @@ static int stm32_spi_resume(struct device *dev) > > ret = pm_runtime_get_sync(dev); > if (ret < 0) { > + pm_runtime_put_noidle(dev); > dev_err(dev, "Unable to power device:%d\n", ret); > return ret; > } > -- > 2.17.1 >