From: Mark Brown <broonie@kernel.org>
To: Gustav Wiklander <gustav.wiklander@axis.com>
Cc: kernel@axis.com, Gustav Wiklander <gustavwi@axis.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spidev: Fix so the module is autoloaded when built as external
Date: Mon, 4 Jan 2021 21:34:37 +0000 [thread overview]
Message-ID: <20210104213437.GM5645@sirena.org.uk> (raw)
In-Reply-To: <20210104153436.20083-1-gustav.wiklander@axis.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Mon, Jan 04, 2021 at 04:34:35PM +0100, Gustav Wiklander wrote:
> From: Gustav Wiklander <gustavwi@axis.com>
>
> The spi framework sets the modalias for the spi device to belong in
> either the acpi device table or the SPI device table. It can never
> be in the OF table. Therefore the spidev driver should populate the
> spi device table rather than the OF table.
>
> NOTE: platform drivers and i2c drivers support aliases in the
> OF device table.
Why is this a good solution rather than ensuring the the OF IDs can be
used directly?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-04 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:34 [PATCH] spi: spidev: Fix so the module is autoloaded when built as external Gustav Wiklander
2021-01-04 21:34 ` Mark Brown [this message]
2021-01-05 9:44 ` Gustav Wiklander
2021-01-07 17:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104213437.GM5645@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gustav.wiklander@axis.com \
--cc=gustavwi@axis.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox