From: Mark Brown <broonie@kernel.org>
To: Meng.Li@windriver.com
Cc: linux-kernel@vger.kernel.org, tudor.ambarus@microchip.com,
vigneshr@ti.com, vadivel.muruganx.ramuthevar@linux.intel.com,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] drivers: spi: cadence: set cqspi to the driver_data field of struct device
Date: Thu, 11 Mar 2021 13:24:23 +0000 [thread overview]
Message-ID: <20210311132423.GC4962@sirena.org.uk> (raw)
In-Reply-To: <20210311091220.3615-1-Meng.Li@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Thu, Mar 11, 2021 at 05:12:20PM +0800, Meng.Li@windriver.com wrote:
> From: Meng Li <Meng.Li@windriver.com>
>
> When initialize cadence qspi controller, it is need to set cqspi
> to the driver_data field of struct device, because it will be
> used in function cqspi_remove/suspend/resume(). Otherwise, there
> will be a crash trace as below when invoking these finctions.
> Call trace:
> cqspi_suspend+0x14/0x44
> dpm_run_callback+0x50/0x1c0
> __device_suspend+0x114/0x514
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-11 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 9:12 [PATCH] drivers: spi: cadence: set cqspi to the driver_data field of struct device Meng.Li
2021-03-11 13:24 ` Mark Brown [this message]
2021-03-11 13:26 ` Mark Brown
2021-03-11 14:05 ` Li, Meng
2021-03-11 15:42 ` Mark Brown
2021-03-11 16:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311132423.GC4962@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Meng.Li@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox