Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml

Pratyush Yadav
2021-03-31T19:40:47Z

On 31/03/21 08:11PM, Mark Brown wrote:
> On Fri, Mar 26, 2021 at 06:30:34PM +0530, Pratyush Yadav wrote:
> > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> >
> > There is no way as of now to have a parent or bus defining properties
> > for child nodes. For now, avoid it in the example to silence warnings on
> > dt_schema_check. We can figure out how to deal with actual dts files
> > later.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

I did take a look by running git log on
Documentation/devicetree/bindings/spi/ and there is no single style
being used. Using "dt-bindings: spi:" is a popular choice. Some other
commits just use "spi:". And then some use "spi: dt-bindings:". The last
commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix
"dt-bindings: spi:".

So on the prefix front I think the subject is good enough. Of course, if
you have any other preference then it can be re-worded but let's first
be clear on what the expectation is. And then let's make sure to apply
it to all future patches uniformly. This way future contributors won't
have to take a guess on what the expected prefix is.

Apart from the prefix is there anything else to improve? IMHO the
subject is good enough but I'm open to suggestions.

--
Regards,
Pratyush Yadav
Texas Instruments Inc.