From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA85C433B4 for ; Tue, 13 Apr 2021 13:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4813A613AE for ; Tue, 13 Apr 2021 13:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231558AbhDMNKV (ORCPT ); Tue, 13 Apr 2021 09:10:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:54298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbhDMNKU (ORCPT ); Tue, 13 Apr 2021 09:10:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7AA6B60FED; Tue, 13 Apr 2021 13:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618319401; bh=vvY4tuETc+Xa/tBMGoEIqFLIZ+8YzeuypXqR4OfLAyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELxWVDoMBrAD202t2nHfsmaQKjmghiJ2yY4IgObjsoxp4A/wUUzSx9dT5+6fHgPxN P2fmbn5LchzAHvl1R7+nH31yLzzFckwydkiRhPXrtyClsoN6Z8oYl96lh9Cq+9XWEd q2oOVYJEnlFkqrE1yuLJf8qCLxhkozXoS6C9w9xQ0mEtUkRPBaP6p3I+oQUOTi98nA yFW/zflfLUl8axi6YLMWWUTvcKwr3p4orVIARvXsDnbFrPqU8YQEOOo3ESyZ7cmEeZ qVGJ7asAxD1kmOOU0Mpx53SYAsvY5NudwMEtpPeFqVyaZeViiF8QI1bfUyen6U66ad 3f7t4lu/c4ynA== Date: Tue, 13 Apr 2021 14:09:39 +0100 From: Mark Brown To: Jay Fang Cc: Geert Uytterhoeven , Wei Xu , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, huangdaode@huawei.com Subject: Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI Message-ID: <20210413130939.GF5586@sirena.org.uk> References: <20210413124715.GE5586@sirena.org.uk> <46a47db2-338e-2ca4-0eac-c2b129ee7b7d@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aPdhxNJGSeOG9wFI" Content-Disposition: inline In-Reply-To: <46a47db2-338e-2ca4-0eac-c2b129ee7b7d@huawei.com> X-Cookie: Shake well before using. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --aPdhxNJGSeOG9wFI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 13, 2021 at 08:59:02PM +0800, Jay Fang wrote: > On 2021/4/13 20:47, Mark Brown wrote: > > On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote: > >> The HiSilicon Kunpeng SPI controller is only present on HiSilicon > >> Kunpeng SoCs. Hence add a dependency on ARCH_HISI, to prevent asking > >> the user about this driver when configuring a kernel without Hisilicon > >> platform support. > > Are you *sure* about this? HiSilicon produce a wide range of SoCs with > > very diverse target markets, this driver looks like it's for enterprise > > stuff while most things guarded by that config option look like they're > > for embedded applications. > SPI_HISI_KUNPENG does not depend on ARCH_HISI. Right, but that's what Geert is proposing to change - the question is does it make sense to do so or not? --aPdhxNJGSeOG9wFI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmB1mBMACgkQJNaLcl1U h9BibAf/UGsOeW1w9mT9jPqivXHv0DUWhbNDh4VWXrThIYf7eiLUwjPWWH6fT9hL XhjtAPDoZyknZByoC3IUCWsOSHFLhcZquBM+10Pto0auYaOvhKwfi0d+KyX9wu2e IwsgxZ0tlRssUroxZaVyLFjcEW6ExmHmibzCAyD4iM4bUt5NXSsIycmBfO8MnIma IO0pUYAljaAmlU96cZONUJW6RvD0RDIJbV2RZ52Kof+J5HtPoNeiBTl9uq+mqEpF jalNdK2F3XyrUjt1McgSSTqs0pVA76fgwDSnGqpaKuL9+ESOMv5EFbIQzmz7FohT QUFwsNBJf+60ufEcL8KF+uw30Ie7EQ== =pm6V -----END PGP SIGNATURE----- --aPdhxNJGSeOG9wFI--