From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0593BC433ED for ; Sun, 2 May 2021 14:04:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC8AF613B0 for ; Sun, 2 May 2021 14:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232575AbhEBOFU (ORCPT ); Sun, 2 May 2021 10:05:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232577AbhEBOFJ (ORCPT ); Sun, 2 May 2021 10:05:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D26EF613AF; Sun, 2 May 2021 14:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619964256; bh=t6uuShaQBFm1A+tFPwZuHJ2zxR2QAMsD2HA7eO5/v58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8Z0uCabMp5Y+EMeehRaaJypX0wLK10wb6hAszwDAJjQSn+PhpuOazUbeH4hoP5ns mc9wdjxvX15xgrgCnY649iFQBRYQJAqvnqHtI9ki95GENEdm+KlpK5rgYUKogJIuF9 Pg230OxjEbYY76yusn4Doa0rI3RKMHydY8kGe+9f2k8GcPEGxgG2ynsymqrTDpVnFl 6hM5joXuiUagPewM0xSqkAgDKyHaeW8ZLgR4SFPBLOlxQBVJhuUOqTCEHOPs2iN566 339UoZoB+7drRFpbZ0wg5W3txOBB0gMQgrASz/3V0xuLnG8plj9cLrtHFXrX1birEC k6SQp06Id5EXA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: David Bauer , Mark Brown , Sasha Levin , linux-spi@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 04/66] spi: ath79: remove spi-master setup and cleanup assignment Date: Sun, 2 May 2021 10:03:09 -0400 Message-Id: <20210502140411.2719301-4-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210502140411.2719301-1-sashal@kernel.org> References: <20210502140411.2719301-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: David Bauer [ Upstream commit ffb597b2bd3cd78b9bfb68f536743cd46dbb2cc4 ] This removes the assignment of setup and cleanup functions for the ath79 target. Assigning the setup-method will lead to 'setup_transfer' not being assigned in spi_bitbang_init. Because of this, performing any TX/RX operation will lead to a kernel oops. Also drop the redundant cleanup assignment, as it's also assigned in spi_bitbang_init. Signed-off-by: David Bauer Link: https://lore.kernel.org/r/20210303160837.165771-2-mail@david-bauer.net Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-ath79.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index 436327fb58de..98ace748cd98 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -156,8 +156,6 @@ static int ath79_spi_probe(struct platform_device *pdev) master->use_gpio_descriptors = true; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32); - master->setup = spi_bitbang_setup; - master->cleanup = spi_bitbang_cleanup; master->flags = SPI_MASTER_GPIO_SS; if (pdata) { master->bus_num = pdata->bus_num; -- 2.30.2