From: Sascha Hauer <sha@pengutronix.de>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: broonie@kernel.org, heiko@sntech.de, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@esmil.dk
Subject: Re: [PATCH v2 2/8] spi: rockchip: Wait for STB status in slave mode tx_xfer
Date: Wed, 5 May 2021 09:59:35 +0200 [thread overview]
Message-ID: <20210505075935.GB10432@pengutronix.de> (raw)
In-Reply-To: <20210427073733.31419-2-jon.lin@rock-chips.com>
Hi Jon Lin,
On Tue, Apr 27, 2021 at 03:37:27PM +0800, Jon Lin wrote:
> +static inline void wait_for_tx_idle(struct rockchip_spi *rs, bool slave_mode)
> {
> unsigned long timeout = jiffies + msecs_to_jiffies(5);
>
> do {
> - if (!(readl_relaxed(rs->regs + ROCKCHIP_SPI_SR) & SR_BUSY))
> - return;
> + if (slave_mode) {
> + if (!(readl_relaxed(rs->regs + ROCKCHIP_SPI_SR) & SR_SLAVE_TX_BUSY) &&
> + !((readl_relaxed(rs->regs + ROCKCHIP_SPI_SR) & SR_BUSY))
> + return;
This doesn't compile. There is one opening brace too much before the
readl_relaxed.
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-05-05 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 7:37 [PATCH v2 1/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-04-27 7:37 ` [PATCH v2 2/8] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
2021-05-05 7:59 ` Sascha Hauer [this message]
2021-04-27 7:37 ` [PATCH v2 3/8] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-04-27 7:37 ` [PATCH v2 4/8] spi: rockchip: add compatible string " Jon Lin
2021-04-27 7:37 ` [PATCH v2 5/8] spi: rockchip: Support cs-gpio Jon Lin
2021-04-27 7:38 ` [PATCH v2 6/8] dt-bindings: spi: spi-rockchip: add description for rk3568 Jon Lin
2021-04-27 7:38 ` [PATCH v2 7/8] spi: rockchip: Add compatible string " Jon Lin
2021-04-27 7:38 ` [PATCH v2 8/8] spi: rockchip: Support SPI_CS_HIGH Jon Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505075935.GB10432@pengutronix.de \
--to=sha@pengutronix.de \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).