From: Mark Brown <broonie@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: imx: mx51-ecspi: Fix low-speed CONFIGREG delay calculation
Date: Mon, 19 Jul 2021 22:12:21 +0100 [thread overview]
Message-ID: <20210719211221.GA35544@sirena.org.uk> (raw)
In-Reply-To: <17bf62a4-af57-1706-f20a-35f9d6cbf9d0@denx.de>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Mon, Jul 19, 2021 at 03:38:55PM +0200, Marek Vasut wrote:
> On 7/19/21 10:20 AM, Uwe Kleine-König wrote:
> > Can it happen that all transfer's spped_hz are zero?
> I don't think so, what kind of spi_message would that be ?
> And even if it was zero, the delay would be 2000000/~0U , so zero as well,
> which I suppose is the best we can do in such a case.
I can see that happening for a controller that didn't set any speed
information with a driver that also didn't set any speed information,
everything is just hoping that the default is fine but only the hardware
is actually setting something. I've not gone and checked if anything
ever insists there absolutely must be something specified in software.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-19 23:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 21:11 [PATCH] spi: imx: mx51-ecspi: Fix low-speed CONFIGREG delay calculation Marek Vasut
2021-07-19 8:20 ` Uwe Kleine-König
2021-07-19 13:38 ` Marek Vasut
2021-07-19 21:12 ` Mark Brown [this message]
2021-07-21 20:18 ` Marek Vasut
2021-07-26 1:46 ` Mark Brown
2021-07-26 6:25 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719211221.GA35544@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).