From: Marek Vasut <marex@denx.de>
To: linux-spi@vger.kernel.org
Cc: "Marek Vasut" <marex@denx.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mark Brown" <broonie@kernel.org>
Subject: [PATCH V2] spi: imx: mx51-ecspi: Fix CONFIGREG delay comment
Date: Tue, 27 Jul 2021 18:04:28 +0200 [thread overview]
Message-ID: <20210727160428.7673-1-marex@denx.de> (raw)
For (2 * 1000000) / min_speed_hz < 10 to be true in naturals with zero,
the min_speed_hz must be above 200000 (i.e. 200001 rounds down to 9, so
the condition triggers). Update the comment. No functional change.
Fixes: 6fd8b8503a0dc ("spi: spi-imx: Fix out-of-order CS/SCLK operation at low speeds")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>
---
V2: It is not 100 kHz, 181 kHz, 222 kHz, it is 200 kHz. Make it so.
---
drivers/spi/spi-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 75a82d6cac785..e3231b501ae06 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -598,7 +598,7 @@ static int mx51_ecspi_prepare_message(struct spi_imx_data *spi_imx,
}
delay = (2 * 1000000) / min_speed_hz;
- if (likely(delay < 10)) /* SCLK is faster than 100 kHz */
+ if (likely(delay < 10)) /* SCLK is faster than 200 kHz */
udelay(delay);
else /* SCLK is _very_ slow */
usleep_range(delay, delay + 10);
--
2.30.2
next reply other threads:[~2021-07-27 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 16:04 Marek Vasut [this message]
2021-07-28 8:37 ` [PATCH V2] spi: imx: mx51-ecspi: Fix CONFIGREG delay comment Uwe Kleine-König
2021-07-28 23:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727160428.7673-1-marex@denx.de \
--to=marex@denx.de \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).