From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marek Vasut <marex@denx.de>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH V2] spi: imx: mx51-ecspi: Fix CONFIGREG delay comment
Date: Wed, 28 Jul 2021 10:37:29 +0200 [thread overview]
Message-ID: <20210728083729.uadiamed6rhszedd@pengutronix.de> (raw)
In-Reply-To: <20210727160428.7673-1-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
On Tue, Jul 27, 2021 at 06:04:28PM +0200, Marek Vasut wrote:
> For (2 * 1000000) / min_speed_hz < 10 to be true in naturals with zero,
> the min_speed_hz must be above 200000 (i.e. 200001 rounds down to 9, so
> the condition triggers). Update the comment. No functional change.
>
> Fixes: 6fd8b8503a0dc ("spi: spi-imx: Fix out-of-order CS/SCLK operation at low speeds")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Mark Brown <broonie@kernel.org>
> ---
> V2: It is not 100 kHz, 181 kHz, 222 kHz, it is 200 kHz. Make it so.
:-)
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks for addressing my comments.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-28 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 16:04 [PATCH V2] spi: imx: mx51-ecspi: Fix CONFIGREG delay comment Marek Vasut
2021-07-28 8:37 ` Uwe Kleine-König [this message]
2021-07-28 23:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728083729.uadiamed6rhszedd@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).