linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhengxun <zhengxunli.mxic@gmail.com>
To: sergei.shtylyov@cogentembedded.com, broonie@kernel.org,
	linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	zhengxunli@mxic.com.tw
Cc: Zhengxun <zhengxunli.mxic@gmail.com>
Subject: [PATCH] memory: renesas-rpc-if: Fix missing setting address
Date: Wed, 18 Aug 2021 16:56:04 +0000	[thread overview]
Message-ID: <20210818165604.22127-1-zhengxunli.mxic@gmail.com> (raw)

In the RPC manual mode, if the data direction is not set
(such as the flash erase command), the address misses the
setting.

Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
---
 drivers/memory/renesas-rpc-if.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 45eed659b0c6..9dd27c6307f7 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
 		}
 		break;
 	default:
+		regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
 		regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
 		regmap_write(rpc->regmap, RPCIF_SMCR,
 			     rpc->smcr | RPCIF_SMCR_SPIE);
-- 
2.17.1


             reply	other threads:[~2021-08-18  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 16:56 Zhengxun [this message]
2021-08-23 11:59 ` [PATCH] memory: renesas-rpc-if: Fix missing setting address Geert Uytterhoeven
2022-04-27 10:26   ` Geert Uytterhoeven
2022-04-27 10:49     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818165604.22127-1-zhengxunli.mxic@gmail.com \
    --to=zhengxunli.mxic@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).