From: Jakub Kicinski <kuba@kernel.org>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, vladimir.oltean@nxp.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH] ptp: don't include ptp_clock_kernel.h in spi.h
Date: Fri, 3 Sep 2021 18:31:40 -0700 [thread overview]
Message-ID: <20210904013140.2377609-1-kuba@kernel.org> (raw)
Commit b42faeee718c ("spi: Add a PTP system timestamp
to the transfer structure") added an include of ptp_clock_kernel.h
to spi.h for struct ptp_system_timestamp but a forward declaration
is enough. Let's use that to limit the number of objects we have
to rebuild every time we touch networking headers.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/spi/spi.c | 1 +
include/linux/spi/spi.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 65d14af9c015..fc778492d254 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -33,6 +33,7 @@
#include <linux/highmem.h>
#include <linux/idr.h>
#include <linux/platform_data/x86/apple.h>
+#include <linux/ptp_clock_kernel.h>
#define CREATE_TRACE_POINTS
#include <trace/events/spi.h>
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 8371bca13729..31f05dd27a6d 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -14,12 +14,12 @@
#include <linux/completion.h>
#include <linux/scatterlist.h>
#include <linux/gpio/consumer.h>
-#include <linux/ptp_clock_kernel.h>
#include <uapi/linux/spi/spi.h>
struct dma_chan;
struct software_node;
+struct ptp_system_timestamp;
struct spi_controller;
struct spi_transfer;
struct spi_controller_mem_ops;
--
2.31.1
next reply other threads:[~2021-09-04 1:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 1:31 Jakub Kicinski [this message]
2021-09-04 9:14 ` [PATCH] ptp: don't include ptp_clock_kernel.h in spi.h Vladimir Oltean
2021-09-06 11:30 ` Mark Brown
2022-01-07 3:56 ` Jakub Kicinski
2022-01-07 12:32 ` Mark Brown
2022-01-07 15:50 ` Jakub Kicinski
2022-01-07 15:58 ` Mark Brown
2022-01-07 18:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210904013140.2377609-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).