From: Mark Brown <broonie@kernel.org>
To: Ville Baillie <villeb@bytesnap.co.uk>
Cc: linux-spi@vger.kernel.org, Dan Sneddon <dan.sneddon@microchip.com>
Subject: Re: [PATCH v2] spi: atmel: Fix PDC transfer setup bug
Date: Mon, 20 Sep 2021 13:28:36 +0100 [thread overview]
Message-ID: <20210920122836.GA13727@sirena.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Thu, Sep 16, 2021 at 02:16:46PM +0000, Ville Baillie wrote:
> Commit 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer
> method") refactored the code and changed a conditional causing
> atmel_spi_dma_map_xfer to never be called in PDC mode. This causes the
> driver to silently fail.
>
> This patch changes the conditional to match the behaviour of the
> previous commit before the refactor.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2021-09-20 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:28 Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-17 7:46 [PATCH v2] spi: atmel: Fix PDC transfer setup bug Ville Baillie
2021-09-17 16:08 ` Dan.Sneddon
2021-10-02 0:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920122836.GA13727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dan.sneddon@microchip.com \
--cc=linux-spi@vger.kernel.org \
--cc=villeb@bytesnap.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).