From: Dan Carpenter <dan.carpenter@oracle.com>
To: Parshuram Thombare <pthombar@cadence.com>
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, jpawar@cadence.com,
mparab@cadence.com
Subject: Re: [PATCH] spi: cadence: fix static checker warning
Date: Mon, 4 Oct 2021 09:49:20 +0300 [thread overview]
Message-ID: <20211004064920.GB2083@kadam> (raw)
In-Reply-To: <1633244658-14702-1-git-send-email-pthombar@cadence.com>
On Sun, Oct 03, 2021 at 09:04:18AM +0200, Parshuram Thombare wrote:
> This patch fixes Smatch static checker warning.
> CDNS_XSPI_CMD_REG_5 is used in ACMD mode and currently
> only STIG mode is enabled which doesn't use CDNS_XSPI_CMD_REG_5
> and hence everything was working in STIG mode.
> Since plan is to use same function cdns_xspi_trigger_command()
> in ACMD mode, increasing size of the array passed to it.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Link: https://lore.kernel.org/linux-spi/20210930134231.GA14363@kili/
> Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
Thanks! There are runtime tools which will detect this read overflow
so let's add a Fixes tag.
Fixes: a16cc8077627 ("spi: cadence: add support for Cadence XSPI controller")
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-04 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 7:04 [PATCH] spi: cadence: fix static checker warning Parshuram Thombare
2021-10-04 6:49 ` Dan Carpenter [this message]
2021-10-04 17:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004064920.GB2083@kadam \
--to=dan.carpenter@oracle.com \
--cc=broonie@kernel.org \
--cc=jpawar@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=pthombar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).