From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jean Delvare <jdelvare@suse.com>, Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, kernel@pengutronix.de,
linux-hwmon@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 02/13] hwmon: adt7x10: Make adt7x10_remove() return void
Date: Mon, 11 Oct 2021 07:19:54 -0700 [thread overview]
Message-ID: <20211011141954.GA1862555@roeck-us.net> (raw)
In-Reply-To: <20211011132754.2479853-3-u.kleine-koenig@pengutronix.de>
On Mon, Oct 11, 2021 at 03:27:43PM +0200, Uwe Kleine-König wrote:
> Up to now adt7x10_remove() returns zero unconditionally. Make it return
> void instead which makes it easier to see in the callers that there is
> no error to handle.
>
> Also the return value of i2c and spi remove callbacks is ignored anyway.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/adt7310.c | 3 ++-
> drivers/hwmon/adt7410.c | 3 ++-
> drivers/hwmon/adt7x10.c | 3 +--
> drivers/hwmon/adt7x10.h | 2 +-
> 4 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/adt7310.c b/drivers/hwmon/adt7310.c
> index 9fad01191620..c40cac16af68 100644
> --- a/drivers/hwmon/adt7310.c
> +++ b/drivers/hwmon/adt7310.c
> @@ -90,7 +90,8 @@ static int adt7310_spi_probe(struct spi_device *spi)
>
> static int adt7310_spi_remove(struct spi_device *spi)
> {
> - return adt7x10_remove(&spi->dev, spi->irq);
> + adt7x10_remove(&spi->dev, spi->irq);
> + return 0;
> }
>
> static const struct spi_device_id adt7310_id[] = {
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 9d80895d0266..973db057427b 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -50,7 +50,8 @@ static int adt7410_i2c_probe(struct i2c_client *client)
>
> static int adt7410_i2c_remove(struct i2c_client *client)
> {
> - return adt7x10_remove(&client->dev, client->irq);
> + adt7x10_remove(&client->dev, client->irq);
> + return 0;
> }
>
> static const struct i2c_device_id adt7410_ids[] = {
> diff --git a/drivers/hwmon/adt7x10.c b/drivers/hwmon/adt7x10.c
> index 3f03b4cf5858..e9d33aa78a19 100644
> --- a/drivers/hwmon/adt7x10.c
> +++ b/drivers/hwmon/adt7x10.c
> @@ -444,7 +444,7 @@ int adt7x10_probe(struct device *dev, const char *name, int irq,
> }
> EXPORT_SYMBOL_GPL(adt7x10_probe);
>
> -int adt7x10_remove(struct device *dev, int irq)
> +void adt7x10_remove(struct device *dev, int irq)
> {
> struct adt7x10_data *data = dev_get_drvdata(dev);
>
> @@ -457,7 +457,6 @@ int adt7x10_remove(struct device *dev, int irq)
> sysfs_remove_group(&dev->kobj, &adt7x10_group);
> if (data->oldconfig != data->config)
> adt7x10_write_byte(dev, ADT7X10_CONFIG, data->oldconfig);
> - return 0;
> }
> EXPORT_SYMBOL_GPL(adt7x10_remove);
>
> diff --git a/drivers/hwmon/adt7x10.h b/drivers/hwmon/adt7x10.h
> index 21ad15ce3163..a1ae682eb32e 100644
> --- a/drivers/hwmon/adt7x10.h
> +++ b/drivers/hwmon/adt7x10.h
> @@ -26,7 +26,7 @@ struct adt7x10_ops {
>
> int adt7x10_probe(struct device *dev, const char *name, int irq,
> const struct adt7x10_ops *ops);
> -int adt7x10_remove(struct device *dev, int irq);
> +void adt7x10_remove(struct device *dev, int irq);
>
> #ifdef CONFIG_PM_SLEEP
> extern const struct dev_pm_ops adt7x10_dev_pm_ops;
next prev parent reply other threads:[~2021-10-11 14:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 13:27 [PATCH 00/13] Make some spi device drivers return zero in .remove() Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 01/13] drm/panel: s6e63m0: Make s6e63m0_remove() return void Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 02/13] hwmon: adt7x10: Make adt7x10_remove() " Uwe Kleine-König
2021-10-11 14:19 ` Guenter Roeck [this message]
2021-10-11 13:27 ` [PATCH 03/13] hwmon: max31722: Warn about failure to put device in stand-by in .remove() Uwe Kleine-König
2021-10-11 13:41 ` Hennerich, Michael
2021-10-11 13:27 ` [PATCH 04/13] input: adxl34xx: Make adxl34x_remove() return void Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 05/13] input: touchscreen: tsc200x: Make tsc200x_remove() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 06/13] media: cxd2880: Eliminate dead code Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 07/13] mfd: mc13xxx: Make mc13xxx_common_exit() return void Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 08/13] mfd: stmpe: Make stmpe_remove() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 09/13] mfd: tps65912: Make tps65912_device_exit() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 10/13] serial: max310x: Make max310x_remove() " Uwe Kleine-König
2021-10-11 13:51 ` Greg Kroah-Hartman
2021-10-11 13:27 ` [PATCH 11/13] serial: sc16is7xx: Make sc16is7xx_remove() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 12/13] staging: fbtft: Make fbtft_remove_common() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 13/13] tpm: st33zp24: Make st33zp24_remove() " Uwe Kleine-König
2021-10-12 16:47 ` Jarkko Sakkinen
2021-10-12 17:40 ` Uwe Kleine-König
2021-10-12 17:46 ` Jarkko Sakkinen
2021-10-11 20:42 ` [PATCH 00/13] Make some spi device drivers return zero in .remove() Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011141954.GA1862555@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).