From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-spi-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F1088C433F5
	for <linux-spi@archiver.kernel.org>; Thu, 16 Dec 2021 10:51:06 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231593AbhLPKvG (ORCPT <rfc822;linux-spi@archiver.kernel.org>);
        Thu, 16 Dec 2021 05:51:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47780 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231342AbhLPKvG (ORCPT
        <rfc822;linux-spi@vger.kernel.org>); Thu, 16 Dec 2021 05:51:06 -0500
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA52C061574
        for <linux-spi@vger.kernel.org>; Thu, 16 Dec 2021 02:51:06 -0800 (PST)
Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        (Authenticated sender: bbrezillon)
        by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C919E1F41707;
        Thu, 16 Dec 2021 10:51:03 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail;
        t=1639651864; bh=Kb3GFiAP4VKs2PH1LsTH++5f7aDy8+6y6PgEMvdEjLU=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=jOuN7cRuBx+COn8Wk4l2LPzJvQyzgVnAP76iSjKF976ecvtHrb8TgB9XJF1VPtC/n
         SgoqpDk39YVVRXQpyWl5QAvprAYsXWDj67HHVLa31cFpx4vaRxTKgXZK4BRJSV5eAm
         zb4meOJnXBd5PgeXcBGbXOu2li6bVfQ6Duy9gAY4RNjHD3cNRS/BUJcAMWZMa2dlRv
         +sSiRDIfLHqYe7xFFffDGeCLuJAJck4WcwxNrgHq1QBzLRZXqNmGHnNzXcyHpXoxae
         OomarSwXG5N5wE888mUrdwxPRwZuTDzvm0uxr5IulVigclxe7DLJMIUGbAx2UKRZV7
         kj+QP5KWohbAA==
Date:   Thu, 16 Dec 2021 11:51:00 +0100
From:   Boris Brezillon <boris.brezillon@collabora.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Mark Brown <broonie@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Michael Walle <michael@walle.cc>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Mauro Lima <mauro.lima@eclypsium.com>,
        Alexander Sverdlin <alexander.sverdlin@nokia.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Hans-Gert Dahmen <hans-gert.dahmen@immu.ne>,
        linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v4 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM
Message-ID: <20211216115100.448351e4@collabora.com>
In-Reply-To: <20211118130543.11179-3-mika.westerberg@linux.intel.com>
References: <20211118130543.11179-1-mika.westerberg@linux.intel.com>
        <20211118130543.11179-3-mika.westerberg@linux.intel.com>
Organization: Collabora
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-spi.vger.kernel.org>
X-Mailing-List: linux-spi@vger.kernel.org

On Thu, 18 Nov 2021 16:05:42 +0300
Mika Westerberg <mika.westerberg@linux.intel.com> wrote:

> +static bool intel_spi_cmp_mem_op(const struct intel_spi_mem_op *iop,
> +				 const struct spi_mem_op *op)
> +{
> +	if (iop->mem_op.cmd.nbytes != op->cmd.nbytes ||
> +	    iop->mem_op.cmd.buswidth != op->cmd.buswidth ||
> +	    iop->mem_op.cmd.dtr != op->cmd.dtr ||
> +	    iop->mem_op.cmd.opcode != op->cmd.opcode)
> +		return false;
> +
> +	if (iop->mem_op.addr.nbytes) {
> +		if (iop->mem_op.addr.nbytes != op->addr.nbytes ||
> +		    iop->mem_op.addr.dtr != op->addr.dtr)
> +			return false;
> +	}

Hm, are you sure you want to allow op->addr.nbytes > 0 when
iop->mem_op.addr.nbytes == 0? Feels like the command should be reported
as unsupported in that case. Unless 0 is a wildcard meaning 'any', but
that would be confusing, since operations with 0 address bytes are
valid, and I actually expect the number of address cycles to be fixed 
or bounded.

> +
> +	if (iop->mem_op.data.dir != op->data.dir ||
> +	    iop->mem_op.data.dtr != op->data.dtr)
> +		return false;
> +
> +	if (iop->mem_op.data.dir != SPI_MEM_NO_DATA) {
> +		if (iop->mem_op.data.buswidth != op->data.buswidth)
> +			return false;
> +	}
> +
> +	return true;
> +}