From: Stefan Binding <sbinding@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Stefan Binding <sbinding@opensource.cirrus.com>
Subject: [PATCH v6 1/9] spi: Make spi_alloc_device and spi_add_device public again
Date: Fri, 21 Jan 2022 17:24:23 +0000 [thread overview]
Message-ID: <20220121172431.6876-2-sbinding@opensource.cirrus.com> (raw)
In-Reply-To: <20220121172431.6876-1-sbinding@opensource.cirrus.com>
This functions were previously made private since they
were not used. However, these functions will be needed
again.
Partial revert of commit da21fde0fdb3
("spi: Make several public functions private to spi.c")
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
drivers/spi/spi.c | 6 ++++--
include/linux/spi/spi.h | 12 ++++++++++++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 4599b121d744..1eb84101c4ad 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -532,7 +532,7 @@ static DEFINE_MUTEX(board_lock);
*
* Return: a pointer to the new device, or NULL.
*/
-static struct spi_device *spi_alloc_device(struct spi_controller *ctlr)
+struct spi_device *spi_alloc_device(struct spi_controller *ctlr)
{
struct spi_device *spi;
@@ -557,6 +557,7 @@ static struct spi_device *spi_alloc_device(struct spi_controller *ctlr)
device_initialize(&spi->dev);
return spi;
}
+EXPORT_SYMBOL_GPL(spi_alloc_device);
static void spi_dev_set_name(struct spi_device *spi)
{
@@ -652,7 +653,7 @@ static int __spi_add_device(struct spi_device *spi)
*
* Return: 0 on success; negative errno on failure
*/
-static int spi_add_device(struct spi_device *spi)
+int spi_add_device(struct spi_device *spi)
{
struct spi_controller *ctlr = spi->controller;
struct device *dev = ctlr->dev.parent;
@@ -673,6 +674,7 @@ static int spi_add_device(struct spi_device *spi)
mutex_unlock(&ctlr->add_lock);
return status;
}
+EXPORT_SYMBOL_GPL(spi_add_device);
static int spi_add_device_locked(struct spi_device *spi)
{
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 7ab3fed7b804..0346a3ff27fd 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -1452,7 +1452,19 @@ spi_register_board_info(struct spi_board_info const *info, unsigned n)
* use spi_new_device() to describe each device. You can also call
* spi_unregister_device() to start making that device vanish, but
* normally that would be handled by spi_unregister_controller().
+ *
+ * You can also use spi_alloc_device() and spi_add_device() to use a two
+ * stage registration sequence for each spi_device. This gives the caller
+ * some more control over the spi_device structure before it is registered,
+ * but requires that caller to initialize fields that would otherwise
+ * be defined using the board info.
*/
+extern struct spi_device *
+spi_alloc_device(struct spi_controller *ctlr);
+
+extern int
+spi_add_device(struct spi_device *spi);
+
extern struct spi_device *
spi_new_device(struct spi_controller *, struct spi_board_info *);
--
2.25.1
next prev parent reply other threads:[~2022-01-21 17:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 17:24 [PATCH v6 0/9] Support Spi in i2c-multi-instantiate driver Stefan Binding
2022-01-21 17:24 ` Stefan Binding [this message]
2022-02-01 14:26 ` [PATCH v6 1/9] spi: Make spi_alloc_device and spi_add_device public again Hans de Goede
2022-02-01 14:52 ` Rafael J. Wysocki
2022-02-01 14:54 ` Hans de Goede
2022-01-21 17:24 ` [PATCH v6 2/9] spi: Create helper API to lookup ACPI info for spi device Stefan Binding
2022-02-01 14:28 ` Hans de Goede
2022-02-01 17:28 ` Stefan Binding
2022-02-01 17:37 ` Mark Brown
2022-01-21 17:24 ` [PATCH v6 3/9] spi: Support selection of the index of the ACPI Spi Resource before alloc Stefan Binding
2022-02-01 14:29 ` Hans de Goede
2022-01-21 17:24 ` [PATCH v6 4/9] spi: Add API to count spi acpi resources Stefan Binding
2022-02-01 14:42 ` Hans de Goede
2022-01-21 17:24 ` [PATCH v6 5/9] platform/x86: i2c-multi-instantiate: Rename it for a generic serial driver name Stefan Binding
2022-02-01 14:55 ` Hans de Goede
2022-01-21 17:24 ` [PATCH v6 6/9] platform/x86: serial-multi-instantiate: Reorganize I2C functions Stefan Binding
2022-02-01 14:59 ` Hans de Goede
2022-01-21 17:24 ` [PATCH v6 7/9] platform/x86: serial-multi-instantiate: Add SPI support Stefan Binding
2022-02-01 15:02 ` Hans de Goede
2022-02-02 8:55 ` Hans de Goede
2022-01-21 17:24 ` [PATCH v6 8/9] ALSA: hda/realtek: Add support for HP Laptops Stefan Binding
2022-02-02 9:05 ` Takashi Iwai
2022-02-02 16:58 ` Hans de Goede
2022-02-02 17:19 ` Takashi Iwai
2022-01-21 17:24 ` [PATCH v6 9/9] ACPI / scan: Create platform device for CS35L41 Stefan Binding
2022-02-01 15:03 ` Hans de Goede
2022-02-01 14:25 ` [PATCH v6 0/9] Support Spi in i2c-multi-instantiate driver Hans de Goede
2022-02-01 17:18 ` (subset) " Mark Brown
2022-02-01 17:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121172431.6876-2-sbinding@opensource.cirrus.com \
--to=sbinding@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).