linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Jaime Liao <jaimeliao@mxic.com.tw>
Subject: Re: [PATCH v10 00/13] External ECC engines & Macronix support
Date: Fri, 28 Jan 2022 09:08:12 +0100	[thread overview]
Message-ID: <20220128090812.5b7a5982@xps13> (raw)
In-Reply-To: <YfL5ApsG7c619+R0@sirena.org.uk>

Hi Mark,

broonie@kernel.org wrote on Thu, 27 Jan 2022 19:56:50 +0000:

> On Thu, Jan 27, 2022 at 10:17:55AM +0100, Miquel Raynal wrote:
> > Hello all,
> > 
> > I've applied the beginning of the series (bindings + ECC part) in a
> > branch named spi-mem-ecc on the MTD korg repository. I already applied
> > this second halve on top of the spi-mem-ecc branch but there was a
> > misunderstanding and they ended up not being fully reviewed. Hence here
> > there are once again, there are no changes since v9 beside the rebase.  
> 
> This looks good, please send a pull request.

Great thanks!

> In general for future reference if there's patches for one of my
> subsystems that I've not explicitly commented on I'm probably expecting
> to apply them.

Oh yeah this is very clear, but as this series heavily depends on some
core MTD changes as well, it was decided that everything would be merged
in one operation and that's why I started constructing the spi-mem-ecc
branch, which touches four different 'cores': nand, spi-nand, spi,
spi-mem.

Because of the last minute reviews right before the beginning
of the merge window I decided not to apply the second halve of the
series too quickly and delayed the whole patchset including the
previous patches which had no interest on their own.

> On Fri, Nov 26, 2021 at 03:10:59PM +0100, Miquel Raynal wrote:
> 
> > If you acknowledge the SPI bits I believe I can carry the entire series
> > through the MTD tree. If you fear conflicts and need an immutable tag I
> > can also do that.  
> 
> It'd be good to have the tag just in case, there's generally a lot of
> work in this area.
> 
> Reviewed-by: Mark Brown <broonie@kernel.org>

As three patches in this series were new/reworked I dropped your tag
there. I should have asked you again. Shall I add them (back) to the
following patches?

	spi: cadence-quadspi: Provide a capability structure
	spi: mxic: Provide a capability structure
	spi: spi-mem: Introduce a capability structure

Thanks,
Miquèl

  reply	other threads:[~2022-01-28  8:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27  9:17 [PATCH v10 00/13] External ECC engines & Macronix support Miquel Raynal
2022-01-27  9:17 ` [PATCH v10 01/13] spi: spi-mem: Introduce a capability structure Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:17 ` [PATCH v10 02/13] spi: spi-mem: Check the controller extra capabilities Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:17 ` [PATCH v10 03/13] spi: cadence-quadspi: Provide a capability structure Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:17 ` [PATCH v10 04/13] spi: mxic: " Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 05/13] spi: spi-mem: Kill the spi_mem_dtr_supports_op() helper Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 06/13] spi: spi-mem: Add an ecc parameter to the spi_mem_op structure Miquel Raynal
2022-01-28  8:03   ` Tudor.Ambarus
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 07/13] mtd: spinand: Delay a little bit the dirmap creation Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 08/13] mtd: spinand: Create direct mapping descriptors for ECC operations Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 09/13] spi: mxic: Fix the transmit path Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 10/13] spi: mxic: Create a helper to configure the controller before an operation Miquel Raynal
2022-01-31 16:22   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 11/13] spi: mxic: Create a helper to ease the start of " Miquel Raynal
2022-01-31 16:21   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 12/13] spi: mxic: Add support for direct mapping Miquel Raynal
2022-01-31 16:21   ` Miquel Raynal
2022-01-27  9:18 ` [PATCH v10 13/13] spi: mxic: Add support for pipelined ECC operations Miquel Raynal
2022-01-31 16:21   ` Miquel Raynal
2022-01-27 19:56 ` [PATCH v10 00/13] External ECC engines & Macronix support Mark Brown
2022-01-28  8:08   ` Miquel Raynal [this message]
2022-01-28 22:34     ` Mark Brown
2022-01-31 13:49       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128090812.5b7a5982@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=boris.brezillon@collabora.com \
    --cc=broonie@kernel.org \
    --cc=jaimeliao@mxic.com.tw \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).