From: Marek Vasut <marex@denx.de>
To: linux-spi@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>, Dinh Nguyen <dinguyen@kernel.org>,
Pratyush Yadav <p.yadav@ti.com>
Subject: [PATCH] [RFC] spi: cadence-quadspi: Disable DAC on SoCFPGA
Date: Mon, 21 Feb 2022 05:32:38 +0100 [thread overview]
Message-ID: <20220221043238.295369-1-marex@denx.de> (raw)
On SoCFPGA Gen5, DAC memcpy_fromio() in cqspi_direct_read_execute()
leads to data abort, disable DAC to avoid triggering it:
Unhandled fault: imprecise external abort (0x1406) at 0x0400d3e9
[0400d3e9] *pgd=00000000
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Pratyush Yadav <p.yadav@ti.com>
---
drivers/spi/spi-cadence-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index b808c94641fa6..65f2c2449be09 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1870,7 +1870,7 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = {
};
static const struct cqspi_driver_platdata socfpga_qspi = {
- .quirks = CQSPI_NO_SUPPORT_WR_COMPLETION,
+ .quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_NO_SUPPORT_WR_COMPLETION,
};
static const struct cqspi_driver_platdata versal_ospi = {
--
2.34.1
next reply other threads:[~2022-02-21 4:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 4:32 Marek Vasut [this message]
2022-02-21 16:38 ` [PATCH] [RFC] spi: cadence-quadspi: Disable DAC on SoCFPGA Dinh Nguyen
2022-02-21 17:05 ` Marek Vasut
2022-02-22 15:49 ` Dinh Nguyen
2022-02-22 18:30 ` Marek Vasut
2022-02-22 21:32 ` Dinh Nguyen
2022-02-23 0:54 ` Marek Vasut
2022-02-23 16:28 ` Dinh Nguyen
2022-02-23 16:43 ` Marek Vasut
2022-02-23 16:46 ` Dinh Nguyen
2022-02-23 17:16 ` Marek Vasut
2022-02-23 22:18 ` Dinh Nguyen
2022-02-23 23:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221043238.295369-1-marex@denx.de \
--to=marex@denx.de \
--cc=dinguyen@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.yadav@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).